Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCE213D0C09 for ; Mon, 25 May 2026 07:16:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779693394; cv=none; b=L+kM+K53y6aRfomEhh6jG2yhQqULOzTEXGz+fUQKfocJoCsDBNqgutbflnMj1dQ8RzhGhZo6J2AoT7+6ku7uEO9JOAv/oBsdAi6HPJ09JmYQSVjIvyL4UJEmDIz+lHmVELzc+j6kOV0gnVe0fZFb1PgyykNNxsTuc7oowQATt3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779693394; c=relaxed/simple; bh=tWgd/SEfc+JK++qJsXDUlul/VoKzD8XDZqfTfUFVDVY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Ie7pO41H5YVwGajRIcqwtmAWCNNyP7UJ56decLzDhBlur8EFhGbc5C1F49rR2I59XWDF8Bza40jHweDNOdNJQYFhsm41+DJaQYheCULeqrnWFDGDSOnCiLlCLzuXQxh9Ug6/bvKj1YanYmMC4dDUHtUpFFkuCM6t/e13vtDKpdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qH0TmiON; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qH0TmiON" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4905529b933so10439365e9.0 for ; Mon, 25 May 2026 00:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779693391; x=1780298191; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=q9k9e6Xf+MNzWVgNPNHN8tTLfksKQSlXwsLl9xzbAfE=; b=qH0TmiONeUPAdDHEinCBFFaPCkzaZ99lDiDz7zjMVt46TdEKjsNI+B53JVBG75xq3w zN7rCuh5AzneT91VsknP3XdOmCb8eLlGO1N41eYTJDJlQiHxIrdSUiQWodv/5badUAD/ jkWUmqHEw3lBDVcS8afRoIQhxsfl24yGEX6UELQYJpAZEUu7P/o76uxwxgWD5l7OKqdH 8LY1ELSYjPVRV+rtn62ffcjXcLYOney2Kr+EbD1rK5R2TY34XivFCrNBSnozqEVdxViV x2wMLvTczxs/g9jbyTGBE5ImAVwIXXZwlahDSytGXdaGNO4KXpD27vf4oSvD1+eiBdQs VA+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779693391; x=1780298191; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q9k9e6Xf+MNzWVgNPNHN8tTLfksKQSlXwsLl9xzbAfE=; b=GwSKEz1z6Lq+sG+3GXCz6TXa6oM7RE2gcOMYaX1+P5HxzYtePiLQkOv2ZkOjUHnXPH 3vWAOle2YppsY8aTaz2JezGOQ/fuOWkfmHWvjQcNwOsqB1ySiTgSR5jZfBYpFe9P/uJw 5ToHOnJT/iYpxmHZgv3grTAFSqtja5QYXWoJqnOyk3+KetGHxQkzIuZUIWLddqbwVw9C VKux158UA6cMLrPBI5gI2M4bWatCuOTr+M+PhQX9fGu76qsHw3kO3Ue3ug2b+oN8ssSN aiJEBNMZ16j/8aGFFFXISbUTf/YrpJ7ZJIegZ0BgTphczpi8aMsG1ZNg1oSOCB/cztJ8 72/Q== X-Forwarded-Encrypted: i=1; AFNElJ8TpkRcQfIW8s1kF95lqdNvb9JWaxY5Vea9Iq3NRtaj6eD2YhlbCj1hpw2ER+aqK8YAFYgRgX2+dDkJQHVcZ0U=@vger.kernel.org X-Gm-Message-State: AOJu0Yzs1chqwK+YcroNzueW9/rnAn/fod2Ia3JNtvrCUaNzpAOLjh0H yuTuEQvsnNgyonWPsA189eAKt47Rad2ObTNdBpZkKjM8bU8v8/vgmeAp X-Gm-Gg: Acq92OGoa5qXSAczAI80SUjwEF5Abmz6DU+plJ8dGdmJuVZx8YAD7V6mbARVigPqpdz rgMfGZrUUingK94axGoefNMCx7wE6E/mrMIhi8IWZ0IpiQhuZQF1waBVR/skaIbeFVTFmrSV0ET 3tnx8dJBwyK3t3FFtCtnZ4HEPXlCt+cb9TM2FsqQWISrFI9GQKRhH4vqsI+RSwlFP+KwGw3LNhJ Ouim8XeGr3wSMrX2u0hASJ5mG3lVI/lhgBgZL0qG2gHUbjTL1AaAe7D/8qWNWLHPjWiUvgDyN3i TAzokPRNzh+yodpgIOLxkQWAl48L3OGK3B2vv6Uz+3yPDH2L5bd2OQwZrqK0/aEgHgqDc0C7K3v bAZsbnFq+AkozXo29WdfScwC8FWkG8/UvgYYR3TsZBP6UMrv0d551YpYWFU3JJ7L44SNxJj/Ev5 YpQ8EhxCf9GfyOGsH6lSu9GGI= X-Received: by 2002:a05:600c:a402:b0:48e:6db3:ff3a with SMTP id 5b1f17b1804b1-490426d079cmr152408125e9.16.1779693391151; Mon, 25 May 2026 00:16:31 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49042aec059sm93042295e9.28.2026.05.25.00.16.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 00:16:30 -0700 (PDT) Date: Mon, 25 May 2026 10:16:27 +0300 From: Dan Carpenter To: Nuno =?iso-8859-1?Q?S=E1?= Cc: Jonathan Cameron , David Lechner , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] iio: core: fix uninitialized data in debugfs Message-ID: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding If *ppos is non-zero then simple_write_to_buffer() will not initialize the start of buf[]. Non zero values for *ppos aren't going to work anyway. Test for them at the start of the function and return -EINVAL. Fixes: 6d5dd486c715 ("iio: core: make use of simple_write_to_buffer()") Signed-off-by: Dan Carpenter --- The original copy_from_user() code was better: https://staticthinking.wordpress.com/2026/05/23/simple_write_to_buffer-is-complicated/ --- drivers/iio/industrialio-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c index bd6f4f9f4533..1308a534582b 100644 --- a/drivers/iio/industrialio-core.c +++ b/drivers/iio/industrialio-core.c @@ -419,7 +419,7 @@ static ssize_t iio_debugfs_write_reg(struct file *file, char buf[80]; int ret; - if (count >= sizeof(buf)) + if (*ppos != 0 || count >= sizeof(buf)) return -EINVAL; ret = simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, userbuf, -- 2.53.0