Date: Wed, 3 Jun 2026 09:32:13 +0300
From: Dan Carpenter <error27@gmail.com>
To: Jad Keskes <inasj268@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-iio@vger.kernel.org,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2] staging: iio: addac: fix CamelCase naming in adt7316
Message-ID: <ah_Kbff-c38NWV66@stanley.mountain>
References: <20260602190308.158051-1-inasj268@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260602190308.158051-1-inasj268@gmail.com>

On Tue, Jun 02, 2026 at 08:03:08PM +0100, Jad Keskes wrote:
> checkpatch flagged a few CamelCase names in this driver.
> AIN and DAC prefixes are lowercased as standard kernel style.

The AIN things aren't an issue and checkpatch doesn't complain
about them.

> Vref is kept capitalized since V stands for Voltage and is a
> proper technical abbreviation.
> 
> DA_AB and DA_CD are renamed to dac_ab and dac_cd to match the
> register constants ADT7316_VREF_BYPASS_DAC_AB and
> ADT7316_VREF_BYPASS_DAC_CD that they reference.

This sort of change would need to be in its own commit.  (We're
dropping the rest of the commit anyway).  The difference
between DA and DAC is not totally clear to me...  The
adt7316_show_DAC_2Vref_ch_mask() function only seems to deal
with DA but the adt7316_store_DAC_2Vref_ch_mask() does stuff
with both.  So I'm not sure I understand the naming.  (I have
not investigated and this is my first time to look at this
code).

regards,
dan carpenter