Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F68FCD8CAC for ; Tue, 9 Jun 2026 08:00:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wWrNa-00026e-L2; Tue, 09 Jun 2026 04:00:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wWrNY-00024s-TL for qemu-devel@nongnu.org; Tue, 09 Jun 2026 04:00:09 -0400 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wWrNX-0003gz-2E for qemu-devel@nongnu.org; Tue, 09 Jun 2026 04:00:08 -0400 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8DAB9601DC; Tue, 9 Jun 2026 07:59:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 764311F00893; Tue, 9 Jun 2026 07:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780991997; bh=JjIHINBJ+TVgPkPp7OY8mWN17uU2ZKmJJBnHQlO84uo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=D6xBcyV/e1m+STI0YgFY9nBPSzA7GNoLbMyXe+zLA/p+kV9ranpSrN2STebf+xsIu hmaqm8ggWXJf8guVPORMCizsHvUCgXXQgJLJEI95JBzI/VVIPvm/ygsx2NKtwvv23l UvvevhmEK3FmFh+rrA2y31efOAJO7+eVMNBq3pApZiWY6u+Xr9iIsWh9NcnGL3zZun ma8LS6Ml2NZvmfV4lU+Db907c6pAgvtWsIsxDvCeuTdkhdJYCtmcmHCFLH6SKAQxRL JompR3PTokrTFlRhweXZWisUUEWCH/PLnWaVZ2eb3MDz4rNf7wB7B9OTOigJGBfXgO DErivyqoS+3jQ== Date: Tue, 9 Jun 2026 13:20:58 +0530 From: Naveen N Rao To: Paolo Bonzini , qemu-devel Cc: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Eduardo Habkost , Eric Blake , Markus Armbruster , Marcelo Tosatti , Zhao Liu , Nikunj A Dadhania , Tom Lendacky , Michael Roth , Roy Hopkins , Srikanth Aithal , Kim Phillips , Joerg Roedel Subject: Re: [PATCH v4 0/9] target/i386: SEV: Add support for enabling VMSA SEV features Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2600:3c04:e001:324:0:1991:8:25; envelope-from=naveen@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Paolo, On Wed, May 20, 2026 at 06:57:53PM +0530, Naveen N Rao (AMD) wrote: > This series adds support for enabling VMSA SEV features for SEV-SNP > guests through the Qemu command line. This is already supported for IGVM > files, so some of that code has been generalized and reused. > > The primary change w.r.t v3 (apart from rebasing and targeting v11.1) is > a change to patch 6/9 to restrict debug-swap to SEV-SNP guests due to a > compatibility issue with SEV-ES guests and pflash, discussed here: > http://lore.kernel.org/r/fcqjl5a7m27f2mfpblnhgmozbipdjmvpdyk3m5hhzwcenp4cpg@m2ooa7ykrcvs > > I plan to post a workaround for that separately. For that reason, I have > retained patch 5/9 so that enabling debug-swap for SEV-ES guests will be > a simpler subsequent change. > > The only other concern has been around patch 8/9 adding a new > tsc-frequency property on sev-snp-guest object (and not re-using the one > on the cpu object). If that's required/possible, I would appreciate some > help since I've been unable to get that working. Can you please review and let me know if you have any concerns with this series? Thanks, Naveen