Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 324F73BADA3 for ; Thu, 11 Jun 2026 08:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781168388; cv=none; b=oINXxpCjebmSe7UivrpkeN12d3KywlisrO2CMApxwvdEHSdEy52f4MCQkoHauvFWdQE1gsO2Im+bvV0suWsIoZQfKcYIu5mLn86YtzNHRrGZIiQuOPKeJUGTmQ6uPpBRp2oeJAQeEbDR7sNTfms93xNYt5jTAQz+QJkMI/mKjng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781168388; c=relaxed/simple; bh=dcJ3PXExx3tLRItSKrdzU5Pex5Yi6Pv27mfuxht5MF0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=V6huNiqNMIHJRuojtsoG+PofGEaQWmCRlFLgiho8fO94nWggZn1kIbH9a6Vo/YqvN0PyZkrVrxI8U75z/JZac+MaS8w/D35HzeIsrFvdK7rbsMHHPnIMNyBIghJ9PQFK5Xl9cRwCfYWVjfn2XSXpDjZMXPYH5RGdmcnbMFqTvaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NYE55Qki; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NYE55Qki" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-8cce22e029cso10299226d6.0 for ; Thu, 11 Jun 2026 01:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781168386; x=1781773186; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=HEF1tsyp6Y8hUnEjMhRhxS04+FM5QLYCbrwdZPmmq1U=; b=NYE55QkiClyMscHxeJZdojnSldFhuK+Zuwfh4CxQF7psAA9JXTzvofEvE4Le5QsiqE MRVW+joXpwG53Y+cfCfRkwXkEfd7+9PEDMKjGy6qM0oGGQMyyeXU2d9E61S8H/M51ocj m4cKEtlOemIa06FL0npIJZxI65jPpcntDckiheFE8JlfJVlaW9nBjUiqEyDG352MvQmS HziPT9kmFkVtszWLHxeorvZmLdcOzG/AyCtAXnzviShr4nttmo+RZ5UJWvPTYYUY3isS laeFMur8mEcUmY2YxStCBC/CBDbvGgZ7AVuBHhapBJ/eM18xkAGVBzu4cKjbxzOTLy2W y4Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781168386; x=1781773186; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HEF1tsyp6Y8hUnEjMhRhxS04+FM5QLYCbrwdZPmmq1U=; b=Km9VV2yqNMOX6P4alZqsJd99F9R1/yC9LBu0OYz9rbu/gncsKYg/eeU3Incjq6Y47V TwOUeZd7yz5+Pl6uLEEzqPI7D7/5tkHZUmzHKTpfIZjmuqV9FO6Svz217hzja9lD7Moo 1vF1EfALLKoWALfq113IJpdtmx7Ya6KOybvlbku7seQBHN4c26ErmmtilC+p0w1SJRq+ pxeL5ZtkJ0lH1vlc3x57WhLZOJCayrYxmF/po05Fc/AYCqXQHCDJWArqK1snE6KFkhMP OgM17f/OeLY4SiSfY8hJzBFe7GIeXkh3ibhfHKyAtHKZAE8tmzAaK3ZB91jsz65cU61R RMNg== X-Forwarded-Encrypted: i=1; AFNElJ8aiilzPMbGAwRLAq9j8wX2KhG20KHXkYExgBD2GYbPenE3F6+GigBgIZ+O5EpFSKZBSabjBa/sFrN7Bpz6n+s=@vger.kernel.org X-Gm-Message-State: AOJu0Ywfz4LXJD50b/VBL8dgLTxR1PEK04gRb2+VHe2Imx8fXHUa8qj1 PzaQUwmID2wAEPZ7IYh4U2YChTko5mNQmZesIco8ASOlWOTg6ZcS4CGQ489SAiCXhyg= X-Gm-Gg: Acq92OG6h1cR9KfHvtXTvD5BwOtVG6dBfOdIJR4xPz45a7A87a+RPzvMrokW/elXybj LpkkgNcaYWiB1fMwObvapgV23jwxzqRYO6RbbGGogCv5qrfvl+4aBCxZ36n5LGTbuRVR0YVG9Vt Sh9on2+Ehl1xieFEMpSQU1GBrD3sOFGQdrVp6PYPstyWdCc7HNGXvMdmvyPuh5Yi9Ve58gEupt2 S4Ej2EgZRAgXwxlbfpjvnB1ah+eY9DjXy7U+zaJEp2wt0xG+ztj6XYsOxZexY3pqS6nH5eAQMle oMsxatQ6ixXwQAB4fd9RgqgLVd+lFIk47ejDXmlhjlG+Ib06trYxeXDKf/pOzjGMo9DPanSX2ym 9wD1ygebLYunymB0LxzWjZEkiCS7Rm6w0WoFLdr/NUtSGyc4xrXiIUBHROFalz2CZ7dU052C6BI HKtCqbmA3ZuvcGBtRkCAjUoVHhUU8= X-Received: by 2002:a05:6214:5c06:b0:8bd:3440:c024 with SMTP id 6a1803df08f44-8d1e23e6148mr21562146d6.15.1781168386189; Thu, 11 Jun 2026 01:59:46 -0700 (PDT) Received: from localhost ([149.40.50.215]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d1eada9cb3sm12049786d6.33.2026.06.11.01.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 01:59:45 -0700 (PDT) Date: Thu, 11 Jun 2026 10:34:51 +0300 From: Dan Carpenter To: Steve French Cc: Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] smb/client: clean up a type issue in cifs_xattr_get() Message-ID: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The cifs_xattr_get() function returns type int, not ssize_t so declare "rc" as int as well. This has no effect on runtime. Signed-off-by: Dan Carpenter --- fs/smb/client/xattr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/smb/client/xattr.c b/fs/smb/client/xattr.c index 23227f2f9428..5091f6c0d7fe 100644 --- a/fs/smb/client/xattr.c +++ b/fs/smb/client/xattr.c @@ -272,7 +272,7 @@ static int cifs_xattr_get(const struct xattr_handler *handler, struct dentry *dentry, struct inode *inode, const char *name, void *value, size_t size) { - ssize_t rc = -EOPNOTSUPP; + int rc = -EOPNOTSUPP; unsigned int xid; struct super_block *sb = dentry->d_sb; struct cifs_sb_info *cifs_sb = CIFS_SB(sb); @@ -354,7 +354,7 @@ static int cifs_xattr_get(const struct xattr_handler *handler, inode, full_path, &acllen, extra_info); if (IS_ERR(pacl)) { rc = PTR_ERR(pacl); - cifs_dbg(VFS, "%s: error %zd getting sec desc\n", + cifs_dbg(VFS, "%s: error %d getting sec desc\n", __func__, rc); } else { if (value) { -- 2.53.0