Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC06ECD98CC for ; Thu, 11 Jun 2026 13:53:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXfr2-0004Vh-4d; Thu, 11 Jun 2026 09:53:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXfqz-0004VP-RL for qemu-rust@nongnu.org; Thu, 11 Jun 2026 09:53:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXfqy-0003P3-A3 for qemu-rust@nongnu.org; Thu, 11 Jun 2026 09:53:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781186030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/VgrPa3naNK/9zGDRnujqRYVwg/TdAvfTE5hbEKZmls=; b=Ga1uwUeGks//BqN9jURkSDCpdClSD3xe+a7/mBBpYAbuUnOMlajTyyn/LHAyN4s6ZsAykG jSMpggkOum2SLZTMR8Ffwoe3wquHPyzU5dlHL7sHitwyjc7IE2r7klyq7MxL8nzydHjQCY zQFgYcTQwvR7tpr7F/CrQ357QXtAIiM= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-qO_6Y6nINh6Qo7xxqqdyrw-1; Thu, 11 Jun 2026 09:53:49 -0400 X-MC-Unique: qO_6Y6nINh6Qo7xxqqdyrw-1 X-Mimecast-MFC-AGG-ID: qO_6Y6nINh6Qo7xxqqdyrw_1781186028 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-7f582244e9eso27307507b3.3 for ; Thu, 11 Jun 2026 06:53:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781186028; x=1781790828; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/VgrPa3naNK/9zGDRnujqRYVwg/TdAvfTE5hbEKZmls=; b=XFdC44MrL24eKkvNCjZU9psNmJnP0Tm6pOF6gSqYWlxAx9rz4E/OIczXR2R/8Cd2JW JZaaPq7tzZuieJ7og/2rNpRqPfKZm4pr9vjUAtRnnmgwwsLEVT7WaMLCA6rHi4nw+wtg LMAwpI8SCz/ozfTK/M2AvEyHYFjgu98vKkmvqg1jTISH3O03pMR6Y9APyUnAbi/2j7/l P8GB9mSdlOcTIToWDNcO8xpvhq14gQytGOeJ8cCys7Wy1cb+h8D1lDZN9Q2HvLfTNuBj rF7OiKrzn5K/LnUmaSXXyVmDu8t/B9ZoIaWCGUWFwHimJs+RJqXN7rKi5uBbs3YC2cMF /ZRQ== X-Forwarded-Encrypted: i=1; AFNElJ8OP64MP2/TqC0F9sgdsT2iYfA4WjM5Nx8y+AWAJRC1fcH/D6Rj5mvkgwlc/Ekd9GfiPGyX0XgAog8=@nongnu.org X-Gm-Message-State: AOJu0YzjNogvET6/6ULFmToWIr9aRO+eDEc8WMt+O6qCvXsA+Z4ylohk W1KYKA7MpxZu9xs8sZZQpQgeZn5w6inLl3up4mIc96RjKaLNTNCmLNGgwbHqVmlq0Gj8QLiayzC 2uWh7Frlx7taPruAZdW2Gpei7l2BL+KzrMn4LSguiG86o4W9cEIni+HQ= X-Gm-Gg: Acq92OHSuKxxbw67cxB1AVAx0EgfbVaWYpaom0Qo991A6Fi2B6q9lUuRthBgO7QQuZB TKVnE5trs6VW+in7Bt78tWtRhcKi3CTxn6znPrtJvx2iPgLqToYQfSsJW007/Uo5X9xOnDNLiKg kWOcHYR/14rL7yQ8kTP9NP7fSuhCVgCH6mRjpvNce2KaR0wWXfPp2XtB4LUHzk3oQWGisTu8DfY viWokKI2dRrQAVysId47JkMPuX06XVmd9QRGf1WUnww5LAhfCPUOYlJtg5cH0lXlDdfhf4BSOUs tNLg/B/pQ74AjwVwA0myPryN0RED96cG1EAC4uD7NLpcr1ZKq8Xdl4QP9UxPHEfoSQ50WNZzxEL kacEY3AixVV5NpyZKmrLth+JwUg== X-Received: by 2002:a05:690c:885:b0:7dd:489:b56a with SMTP id 00721157ae682-7f65719007bmr30080077b3.25.1781186028059; Thu, 11 Jun 2026 06:53:48 -0700 (PDT) X-Received: by 2002:a05:690c:885:b0:7dd:489:b56a with SMTP id 00721157ae682-7f65719007bmr30079707b3.25.1781186027470; Thu, 11 Jun 2026 06:53:47 -0700 (PDT) Received: from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7f6958cabfesm5548377b3.27.2026.06.11.06.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 06:53:47 -0700 (PDT) Date: Thu, 11 Jun 2026 09:53:45 -0400 From: Peter Xu To: Mark Cave-Ayland Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , Fabiano Rosas , Vladimir Sementsov-Ogievskiy , Peter Maydell , "Dr . David Alan Gilbert" , Eric Blake , Akihiko Odaki , Paolo Bonzini , Kevin Wolf , Sana Sharma , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Juraj Marcin , qemu-rust@nongnu.org, Markus Armbruster Subject: Re: [PATCH v2 05/10] qom: Create object-property-ptr.[ch] Message-ID: References: <20260609172514.2037645-1-peterx@redhat.com> <20260609172514.2037645-6-peterx@redhat.com> <73fe919b-d8eb-4b01-8401-f7ecb418eb11@nutanix.com> MIME-Version: 1.0 In-Reply-To: <73fe919b-d8eb-4b01-8401-f7ecb418eb11@nutanix.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hd-SsXmC2QoQPqpXKN4hL6mXltbYQBxtiQPlR2SiIEw_1781186028 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org On Thu, Jun 11, 2026 at 01:54:54PM +0100, Mark Cave-Ayland wrote: > > @@ -2141,4 +2048,10 @@ char *object_property_help(const char *name, const char *type, > > G_DEFINE_AUTOPTR_CLEANUP_FUNC(Object, object_unref) > > +/* > > + * Object property ptr helpers cannot be included at the beginning of the > > + * file, because it depends on QOM definitions in current header. > > + */ > > +#include "qom/object-property-ptr.h" > > I wonder if possibly we might want to let the caller include the extra > header? But I don't feel too strongly either way. Yes, I didn't try to when drafting, but I also agree it's cleaner. It will need to update existing files (20 .c files) that used the api set. I'll do it if we can reach a consensus on the concept. [...] > Otherwise looks okay to me: > > Reviewed-by: Mark Cave-Ayland Thanks, -- Peter Xu