Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0E8BCD98D2 for ; Thu, 11 Jun 2026 10:07:46 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 7FD7E3E2AD1 for ; Thu, 11 Jun 2026 12:07:45 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 7E9903C2B4B for ; Thu, 11 Jun 2026 12:07:29 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id D2E3160074D for ; Thu, 11 Jun 2026 12:07:28 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2444875B72; Thu, 11 Jun 2026 10:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1781172448; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oRaRw6xxM83Wpprnq5D7Z74SjORgSTPeaePf9Wp9Q1s=; b=gxzeeryXoewyqNsj/59hl3CJb0qIUnHd6P041ARAlQTXQqeJuVa8QA3yGZZJOvleB6G58Z iLnLUkKE697TACNwTyzzo1zflMlmytjErcCbMFCmw5iil4zzX0iQFuAM3dBTTP9qMhobQn /R0WrhE4+bsaB0iQJwfpm0iRoilgcCs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1781172448; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oRaRw6xxM83Wpprnq5D7Z74SjORgSTPeaePf9Wp9Q1s=; b=0q6QaDMXl8ysAyT3rmsEPL+6/jFt5BI1YWXFY0PfpAKf+hmdTHQ89AplWaDdbLlZm32Ao6 4tI39bWww3jz3NBQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gxzeeryX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0q6QaDMX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1781172448; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oRaRw6xxM83Wpprnq5D7Z74SjORgSTPeaePf9Wp9Q1s=; b=gxzeeryXoewyqNsj/59hl3CJb0qIUnHd6P041ARAlQTXQqeJuVa8QA3yGZZJOvleB6G58Z iLnLUkKE697TACNwTyzzo1zflMlmytjErcCbMFCmw5iil4zzX0iQFuAM3dBTTP9qMhobQn /R0WrhE4+bsaB0iQJwfpm0iRoilgcCs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1781172448; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oRaRw6xxM83Wpprnq5D7Z74SjORgSTPeaePf9Wp9Q1s=; b=0q6QaDMXl8ysAyT3rmsEPL+6/jFt5BI1YWXFY0PfpAKf+hmdTHQ89AplWaDdbLlZm32Ao6 4tI39bWww3jz3NBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 085E9779A7; Thu, 11 Jun 2026 10:07:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qJjuOt+IKmpbSgAAD6G6ig (envelope-from ); Thu, 11 Jun 2026 10:07:27 +0000 Date: Thu, 11 Jun 2026 12:07:26 +0200 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <6a2a81a9.159d33f9.2309c6.33c9@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a2a81a9.159d33f9.2309c6.33c9@mx.google.com> X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MISSING_XM_UA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:email,suse.cz:dkim]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 2444875B72 X-Virus-Scanned: clamav-milter 1.0.9 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v5 2/2] firmware/fw_load: add fw_load02 for custom firmware path X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Test Project Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > I would say that it's cleaner to add the save_restore to the tst_test > > structure without the tmpdir value and use > > SAFE_FILE_PRINTF(FW_PATH, "%s", tmpdir) in the test setup. Since if the > > test crashes the test library will still restore the FW_PATH > > The problem here is that we have to use the tmpdir for the custom > folder, because on immutable distribution fw_path will be read-only. And I do ask to split the part where we ask the library to save and restore the value and the part where we set it so that we can have the save restore in the tst_test structure. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp