Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4019C0044D for ; Mon, 16 Mar 2020 15:17:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 672F820674 for ; Mon, 16 Mar 2020 15:17:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 672F820674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDrUD-0001L8-1g for qemu-devel@archiver.kernel.org; Mon, 16 Mar 2020 11:17:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38188) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDpSO-0002TW-1h for qemu-devel@nongnu.org; Mon, 16 Mar 2020 09:07:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDpSN-0002Sq-1Z for qemu-devel@nongnu.org; Mon, 16 Mar 2020 09:06:59 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:32988) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDpSK-0001RJ-8h; Mon, 16 Mar 2020 09:06:56 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 14BA3747E07; Mon, 16 Mar 2020 14:06:53 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id E8F9E747E06; Mon, 16 Mar 2020 14:06:52 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id E6CC6747E00; Mon, 16 Mar 2020 14:06:52 +0100 (CET) Date: Mon, 16 Mar 2020 14:06:52 +0100 (CET) From: BALATON Zoltan To: Markus Armbruster Subject: Re: [PATCH 0/8] Misc hw/ide legacy clean up In-Reply-To: <87lfo0lr9t.fsf@dusky.pond.sub.org> Message-ID: References: <87lfo0lr9t.fsf@dusky.pond.sub.org> User-Agent: Alpine 2.22 (BSF 395 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:738:2001:2001::2001 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , philmd@redhat.com, Mark Cave-Ayland , qemu-devel@nongnu.org, hpoussin@reactos.org, Aleksandar Markovic , Paolo Bonzini , John Snow , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 16 Mar 2020, Markus Armbruster wrote: > BALATON Zoltan writes: >> These are some clean ups to remove more legacy init functions and >> lessen dependence on include/hw/ide.h with some simplifications in >> board code. There should be no functional change. > > PATCH 1 could quote precedence more clearly in the commit message, but > that's detail. > > I don't like PATCH 4. Sent alternative v2 version of patch 7 so you can drop patch 4 if you like, the rest of the series should apply unchanged. Note that there might be some places where MAX_IDE_BUS is defined but not used and current code probably has assumption about this being 2 elsewhere and would break with any other value so other than philosophical there should be no reason to keep this defined everywhere. > PATCH 1-3,5-8: > Reviewed-by: Markus Armbruster Thanks. Regards, BALATON Zoltan