Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14566C18E5B for ; Tue, 17 Mar 2020 14:08:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBAD6205ED for ; Tue, 17 Mar 2020 14:08:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBAD6205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jECtQ-0000ll-3W for qemu-devel@archiver.kernel.org; Tue, 17 Mar 2020 10:08:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45988) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jECsi-0008BV-OE for qemu-devel@nongnu.org; Tue, 17 Mar 2020 10:07:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jECsh-0004CW-GZ for qemu-devel@nongnu.org; Tue, 17 Mar 2020 10:07:44 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:38747) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jECse-0003R9-PN; Tue, 17 Mar 2020 10:07:40 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id C783E746383; Tue, 17 Mar 2020 15:07:36 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id A2E9A7461AE; Tue, 17 Mar 2020 15:07:36 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id A17DD745953; Tue, 17 Mar 2020 15:07:36 +0100 (CET) Date: Tue, 17 Mar 2020 15:07:36 +0100 (CET) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH v2 2/7] hw/ide: Get rid of piix4_init function In-Reply-To: <549ffd77-a020-51c8-96e7-c4afc28ff633@redhat.com> Message-ID: References: <3240656814c804513de08bdbbf318f2f590df241.1584437958.git.balaton@eik.bme.hu> <2038186d-3f18-d430-2305-5697097397e9@redhat.com> <549ffd77-a020-51c8-96e7-c4afc28ff633@redhat.com> User-Agent: Alpine 2.22 (BSF 395 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-1131289978-1584454056=:40468" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:738:2001:2001::2001 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Mark Cave-Ayland , qemu-devel@nongnu.org, hpoussin@reactos.org, Aleksandar Markovic , Paolo Bonzini , John Snow , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-1131289978-1584454056=:40468 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On Tue, 17 Mar 2020, Philippe Mathieu-Daud=C3=A9 wrote: > On 3/17/20 2:50 PM, John Snow wrote: >> On 3/17/20 6:49 AM, Philippe Mathieu-Daud=C3=A9 wrote: >>> On 3/17/20 11:41 AM, Philippe Mathieu-Daud=C3=A9 wrote: >>>> On 3/17/20 10:39 AM, BALATON Zoltan wrote: >>>>> This removes pci_piix4_ide_init() function similar to clean up done= to >>>>> other ide devices. >>>>>=20 >>>>> Signed-off-by: BALATON Zoltan >>>>> Reviewed-by: Mark Cave-Ayland >>>>> Reviewed-by: Markus Armbruster >>>>=20 >>>> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >>>=20 >>> Please disregard this tag (I withdraw it), I mis-read the pci variabl= e >>> was not assigned. >>>=20 >>=20 >> Is there an issue you've noticed, or you are just no longer certain >> enough to give an RB? > > I asked Zoltan there why he was reassigning 'pci' and he replied here: > https://www.mail-archive.com/qemu-block@nongnu.org/msg63324.html > > I don't know enough the PCI API (and don't have time this week to dig i= nto=20 > it) to check how pci->devfn is used (is it populated by a pci_create()=20 > call?). > > pci =3D pci_create_simple_multifunction(pci_bus, PCI_DEVFN(10, 0), > true, TYPE_PIIX4_PCI_DEVICE); > ... > + pci =3D pci_create_simple(pci_bus, pci->devfn + 1, "piix4-ide"); > ... > pci_create_simple(pci_bus, pci->devfn + 2, "piix4-usb-uhci"); > > What annoys me is here -------^^^^^^ I don't know if reassigning the pc= i=20 > variable can have an impact, so as I am not confident I prefer to withd= raw my=20 > review tag. OK, I did not know that's what you were asking about and did not notice=20 this could be a problem. To avoid any doubt I'll send a new version to=20 avoid this shortly. Regards, BALATON Zoltan --3866299591-1131289978-1584454056=:40468--