Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A08CBC433DF for ; Mon, 15 Jun 2020 15:16:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 746202074D for ; Mon, 15 Jun 2020 15:16:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 746202074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkqq8-0006iN-On for qemu-devel@archiver.kernel.org; Mon, 15 Jun 2020 11:16:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkqp1-0005U2-PM for qemu-devel@nongnu.org; Mon, 15 Jun 2020 11:14:51 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:30612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkqoz-0008Fe-8q for qemu-devel@nongnu.org; Mon, 15 Jun 2020 11:14:51 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id CF3ED746331; Mon, 15 Jun 2020 17:14:37 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id B00C3746307; Mon, 15 Jun 2020 17:14:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id AE62974594E; Mon, 15 Jun 2020 17:14:37 +0200 (CEST) Date: Mon, 15 Jun 2020 17:14:37 +0200 (CEST) From: BALATON Zoltan To: Peter Maydell Subject: Re: [PATCH 3/4] sm501: Ignore no-op blits In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (BSF 395 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 11:14:38 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sebastian Bauer , Magnus Damm , QEMU Developers , Aurelien Jarno , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 15 Jun 2020, Peter Maydell wrote: > On Sat, 6 Jun 2020 at 20:22, BALATON Zoltan wrote: >> >> Some guests seem to try source copy blits with same source and dest >> which are no-op so avoid calling pixman for these. > > Are they doing actual source copy blits, or one of the other > currently-unimplemented op types which we currently fall > back to doing as source-copy ? I thought the same but in the cases I've seen the rop was 0xcc which is copy source so it looks like an actual source copy blit (this seems to be an issue in the guest driver, I've notified appropriate people but not sure it's still maintained). Even if it was fallback we wouldn't need to do the copy in this case as it changes nothing so we can optimise this out. When we implement the missing op that would come before this case so this is only for source copy case. >> Signed-off-by: BALATON Zoltan > Reviewed-by: Peter Maydell Thank you, BALATON Zoltan