From: Pekka Enberg Subject: Re: [PATCH] kvm tools: Fix 64-bit assumptions and type uglinesses Date: Sat, 9 Apr 2011 14:37:21 +0300 (EEST) Message-ID: References: <20110409112124.GA15296@elte.hu> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-2114003826-1302349042=:3006" Cc: Pekka Enberg , KVM devel mailing list , gorcunov@gmail.com, asias.hejun@gmail.com To: Ingo Molnar Return-path: Received: from filtteri2.pp.htv.fi ([213.243.153.185]:42036 "EHLO filtteri2.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598Ab1DILhX (ORCPT ); Sat, 9 Apr 2011 07:37:23 -0400 In-Reply-To: <20110409112124.GA15296@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2114003826-1302349042=:3006 Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Sat, 9 Apr 2011, Ingo Molnar wrote: > Make the MIN_RAM_SIZE_MB constant 64-bit on 32-bit systems as well, otherwise > we get this build failure: > > kvm-run.c: In function ‘kvm_cmd_run’: > kvm-run.c:119: error: format ‘%lu’ expects type ‘long unsigned int’, but argument 2 has type ‘u64’ > > Also adjust affected printf format string - this necessiates the use of > the sane Linux definition of u64 instead of the brain-dead int64_t > variant. > > That also allows (and necessiates) the removal of the ugly PRIu64 format > string hackery. Friends don't let friends use PRI* hackeries! :-) Yeah, we definitely should do a tree-wide sweep of s/uint64_t/u64/, etc., and PRI* removal. > Signed-off-by: Ingo Molnar Applied, thanks! Pekka --8323329-2114003826-1302349042=:3006--