Return-Path: Received: from Galois.linutronix.de ([146.0.238.70]:41391 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752730AbdBMVgJ (ORCPT ); Mon, 13 Feb 2017 16:36:09 -0500 Date: Mon, 13 Feb 2017 22:35:59 +0100 (CET) From: Thomas Gleixner To: Linus Torvalds cc: Borislav Petkov , Steven Rostedt , Gabriel C , Mike Galbraith , Greg Kroah-Hartman , stable , Andrew Morton , Ruslan Ruslichenko , Jiri Slaby Subject: Re: Linux 4.9.6 ( Restore IO-APIC irq_chip retrigger callback , breaks my box ) In-Reply-To: Message-ID: References: <20170212211228.iycyl76o4auxk2jy@pd.tnic> <20170213003804.7gt2edclorjlx52p@pd.tnic> <1486953115.5912.4.camel@gmx.de> <20170213204324.mdipw72ueirrkxob@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: stable-owner@vger.kernel.org List-ID: On Mon, 13 Feb 2017, Linus Torvalds wrote: > On Mon, Feb 13, 2017 at 12:43 PM, Borislav Petkov wrote: > > > > FWIW, it really looks like something's tickling this in Gabriel's > > .config. > > > > [ 8.652522] genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus) > > How the hell is that "goldfish_pdev_bus" thing there at all? > > And I'm not talking about the driver being enabled, I'm talking about > the bus probe finding such a device in the first place? > > That thing is supposed to only trigger on virtual hardware in QEMU. > But it must have actually probed successfully in order to have an > interrupt. How is that thing supposed to match anything>? That's easy. arch/x86/platform/goldfish/goldfish.c static int __init goldfish_init(void) { platform_device_register_simple("goldfish_pdev_bus", -1, goldfish_pdev_bus_resources, 2); return 0; } device_initcall(goldfish_init); So it unconditionallyt registers that platform device, which has IRQ 4 as irq resource and the driver happily matches on the platform devices. Wonderful crap, isn't it? It should be made 'depend on BROKEN'. Thanks, tglx