Return-Path: Received: from Galois.linutronix.de ([146.0.238.70]:42574 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbdBNIPh (ORCPT ); Tue, 14 Feb 2017 03:15:37 -0500 Date: Tue, 14 Feb 2017 09:15:26 +0100 (CET) From: Thomas Gleixner To: Linus Torvalds cc: Borislav Petkov , Steven Rostedt , Gabriel C , Mike Galbraith , Greg Kroah-Hartman , stable , Andrew Morton , Ruslan Ruslichenko , Jiri Slaby Subject: Re: Linux 4.9.6 ( Restore IO-APIC irq_chip retrigger callback , breaks my box ) In-Reply-To: Message-ID: References: <20170212211228.iycyl76o4auxk2jy@pd.tnic> <20170213003804.7gt2edclorjlx52p@pd.tnic> <1486953115.5912.4.camel@gmx.de> <20170213204324.mdipw72ueirrkxob@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: stable-owner@vger.kernel.org List-ID: On Mon, 13 Feb 2017, Linus Torvalds wrote: > On Mon, Feb 13, 2017 at 1:35 PM, Thomas Gleixner wrote: > > > > arch/x86/platform/goldfish/goldfish.c > > > > static int __init goldfish_init(void) > > { > > platform_device_register_simple("goldfish_pdev_bus", -1, > > goldfish_pdev_bus_resources, 2); > > return 0; > > } > > device_initcall(goldfish_init); > > > > So it unconditionallyt registers that platform device, which has IRQ 4 as > > irq resource and the driver happily matches on the platform devices. > > > > Wonderful crap, isn't it? It should be made 'depend on BROKEN'. > > Ugh. Yeah, that's crazy. Random hardcoded interfaces that get enabled > by people by mistake. > > And yeah, it's not just the irq. It just randomly sets up memory addresses too. > > That thing needs to be disabled some way. Maybe not marked "broken", > but there needs to be something that actually enables it at runtime > (like a kernel command line option or something like that). > > That said - that code was presumably enabled before too, so why would > this break something? And if this is the cause, we need to figure out > what it is that it then triggers.. I'm on it ...