X-GM-THRID: 6388342428982575104 X-Received: by 10.46.88.70 with SMTP id x6mr1147169ljd.22.1487423768876; Sat, 18 Feb 2017 05:16:08 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.46.33.152 with SMTP id h24ls316287lji.53.gmail; Sat, 18 Feb 2017 05:16:08 -0800 (PST) X-Received: by 10.25.168.20 with SMTP id r20mr1263976lfe.10.1487423768033; Sat, 18 Feb 2017 05:16:08 -0800 (PST) Return-Path: Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr. [192.134.164.83]) by gmr-mx.google.com with ESMTPS id f7si359896wmg.3.2017.02.18.05.16.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Feb 2017 05:16:07 -0800 (PST) Received-SPF: neutral (google.com: 192.134.164.83 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.83; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.83 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.35,174,1484002800"; d="scan'208";a="261082918" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2017 14:16:07 +0100 Date: Sat, 18 Feb 2017 14:16:03 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 1/6] staging: rtl8192e: Replaced comparison to NULL statements In-Reply-To: <20170218071115.GA10540@singhal-Inspiron-5558> Message-ID: References: <20170218071115.GA10540@singhal-Inspiron-5558> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 18 Feb 2017, simran singhal wrote: > This patch corrects check generated by checkpatch.pl by There is not much information in the first line. Use the imperative: Replace comparisons to NULL by ... > replacing comparison to null statements with equivalent > statements in the form of "!x". Actually, they are expressions. An expression returns a value. A statement is performed for its side effects only. julia > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c > index 20260af..bdbd21c 100644 > --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c > +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c > @@ -83,12 +83,12 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst, > netdev_dbg(ieee->dev, "%s(): frame(%d) sentd to: %pM, ieee->dev:%p\n", > __func__, type, Dst, ieee->dev); > > - if (pBA == NULL) { > + if (!pBA) { > netdev_warn(ieee->dev, "pBA is NULL\n"); > return NULL; > } > skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr)); > - if (skb == NULL) > + if (!skb) > return NULL; > > memset(skb->data, 0, sizeof(struct rtllib_hdr_3addr)); > @@ -154,7 +154,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst, > DelbaParamSet.field.TID = pBA->BaParamSet.field.TID; > > skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr)); > - if (skb == NULL) > + if (!skb) > return NULL; > > skb_reserve(skb, ieee->tx_headroom); > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218071115.GA10540%40singhal-Inspiron-5558. > For more options, visit https://groups.google.com/d/optout. >