From: julia.lawall@lip6.fr (Julia Lawall) Date: Fri, 8 Sep 2017 09:15:52 +0200 (CEST) Subject: [Cocci] Checking statement order for patch generation with SmPL support In-Reply-To: References: <2a2b1ae2-ff84-2bda-3701-548dd9ee1edf@users.sourceforge.net> Message-ID: To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr > > Execution can go from queuefree to the top of the loop, to the first if in > > the loop to the second if in the loop that has the dereference. That is > > how loops work. > > I can agree to this view. > > But I find the existence of a loop not so relevant for the source code > search pattern which is discussed. yes it is. If you make a pattern like A ... B It matches A, and then goes forth along all control flow paths, whether forwards or backwards, until it reaches a B. If there is a loop, it will go around the loop and match code that appears before A in terms of line numbers. The fact that in your case both A and B are in the same if branch is irrelevant. > > > >> @@ -1199,14 +1199,11 @@ void dpcm_be_disconnect(struct snd_soc_p > >> stream ? "<-" : "->", dpcm->be->dai_link->name); > >> > >> /* BEs still alive need new FE */ > >> - dpcm_be_reparent(fe, dpcm->be, stream); > >> > >> #ifdef CONFIG_DEBUG_FS > >> - debugfs_remove(dpcm->debugfs_state); > >> #endif > >> list_del(&dpcm->list_be); > >> list_del(&dpcm->list_fe); > >> - kfree(dpcm); > >> } > >> } > >> > >> > >> I find the shown matches also questionable for this test result. > >> Would you like to clarify such software situations a bit more > >> for the desired handling of statement sequences? > > > > The list_for_each_entry_safe operator also makes a loop. > > Yes. - But how could the Coccinelle software know more about this identifier > during execution of the small script ?show_use_after_free3.cocci? than > that it is a macro call in the implementation of the function ?dpcm_be_disconnect? > (when extra include parameters were not specified)? > http://elixir.free-electrons.com/linux/v4.13/source/include/linux/list.h#L542 > http://elixir.free-electrons.com/linux/v4.13/source/sound/soc/soc-pcm.c#L1184 Coccinelle has a number of hard coded heuristics about macros, including knowing that list_for_each and ohter similar things represent loops. > Do you find the minus characters appropriate at the beginning of these three lines? The behavior observed corresponds comepletely to the semantic patch you have written. julia