From: Julia Lawall Date: Mon, 27 Nov 2017 06:42:48 +0000 Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line Message-Id: List-Id: References: <20171126054037.9743-1-logang@deltatee.com> <85bdbab8-8b7e-91a9-7199-a0e39041aef1@deltatee.com> <3fc88c02-b9b6-80a3-0c41-63e0806d34aa@deltatee.com> <1511746526.20482.38.camel@perches.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Logan Gunthorpe , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft On Mon, 27 Nov 2017, Julia Lawall wrote: > > > On Sun, 26 Nov 2017, Joe Perches wrote: > > > On Sun, 2017-11-26 at 19:17 +0100, Julia Lawall wrote: > > > I just assume that a printk that has no KERN_ is adding a > > > newline, which is my understanding of Joe's comment. > > > > More precisely: > > > > Any printk without an initial KERN_CONT prepends a newline > > if the last printk content char emitted that is not part > > of a printk timestamp/header was not a newline. > > Ah, I misunderstood. I thought it was any printk that has no KERN > indicator at all. That I can fix. Although I guess that in that case the whole exercise is pointless? Because every print will at runtime be followed by another print, which will add either the newline or a continuation. julia