Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104;
Date: Sun, 4 Mar 2018 14:03:34 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Rinkle Jain <rinklejain96@gmail.com>
cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, 
    forest@alittletooquiet.net
Subject: Re: [Outreachy kernel] [PATCH v2] staging: vt6655: Fix style violation
 for line ending in '('
In-Reply-To: <20180304072225.GA17701@tic-tac>
Message-ID: <alpine.DEB.2.20.1803041403140.2223@hadrien>
References: <20180304072225.GA17701@tic-tac>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Sun, 4 Mar 2018, Rinkle Jain wrote:

> Replace line ending with '(' with function parameters to resolve
> style issue found by checkpath.
>
> Signed-off-by: Rinkle Jain <rinklejain96@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
> Changes in v2:
> 	- Make better use of the available horizontal space.
> 	- Remove use of a line for ');' in function declarartion.
>
>  drivers/staging/vt6655/baseband.h | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> index b8ee33dcb352..30d9e9d20a39 100644
> --- a/drivers/staging/vt6655/baseband.h
> +++ b/drivers/staging/vt6655/baseband.h
> @@ -46,13 +46,10 @@
>  #define TOP_RATE_2M         0x00200000
>  #define TOP_RATE_1M         0x00100000
>
> -unsigned int
> -BBuGetFrameTime(
> -	unsigned char byPreambleType,
> -	unsigned char byPktType,
> -	unsigned int cbFrameLength,
> -	unsigned short wRate
> -);
> +unsigned int BBuGetFrameTime(unsigned char byPreambleType,
> +			     unsigned char byPktType,
> +			     unsigned int cbFrameLength,
> +			     unsigned short wRate);
>
>  void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
>  		       u16 tx_rate, u8 pkt_type, struct vnt_phy_field *phy);
> --
> 2.14.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180304072225.GA17701%40tic-tac.
> For more options, visit https://groups.google.com/d/optout.
>