Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104;
Date: Sun, 4 Mar 2018 20:04:20 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Dafna Hirschfeld <dafna3@gmail.com>
cc: oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, 
    gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/3] staging: lustre: obdclass:
 Fix comparison to NULL
In-Reply-To: <2af5f92fecc211d04770d19600874f3345f97200.1520153895.git.dafna3@gmail.com>
Message-ID: <alpine.DEB.2.20.1803042003320.2182@hadrien>
References: <cover.1520153895.git.dafna3@gmail.com> <2af5f92fecc211d04770d19600874f3345f97200.1520153895.git.dafna3@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Sun, 4 Mar 2018, Dafna Hirschfeld wrote:

> Replace comparison to NULL with a 'not' operator.
> Issue found with checkpatch.
>
> Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> index e1f4ef2..64cc746 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> @@ -1585,7 +1585,7 @@ int ldebugfs_seq_create(struct dentry *parent, const char *name,
>  	struct dentry *entry;
>
>  	/* Disallow secretly (un)writable entries. */
> -	LASSERT((seq_fops->write == NULL) == ((mode & 0222) == 0));
> +	LASSERT((!seq_fops->write) == ((mode & 0222) == 0));

! actually binds more tightly than ==, but I think that keeping the
parentheses is helpful for clarity.

julia

>
>  	entry = debugfs_create_file(name, mode, parent, data, seq_fops);
>  	if (IS_ERR_OR_NULL(entry))
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2af5f92fecc211d04770d19600874f3345f97200.1520153895.git.dafna3%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>