Received-SPF: neutral (google.com: 192.134.164.83 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.83;
Date: Sun, 4 Mar 2018 20:38:47 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Dafna Hirschfeld <dafna3@gmail.com>
cc: oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, 
    gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 0/3] Cleanup for staging lustre
 obdclass
In-Reply-To: <CAJ1myNQ4EL6od8MOEh7JpoFUr6fKS7bwvcS0P8QDP5fDc4nCew@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1803042038350.2182@hadrien>
References: <cover.1520153895.git.dafna3@gmail.com> <alpine.DEB.2.20.1803042005060.2182@hadrien> <CAJ1myNQ4EL6od8MOEh7JpoFUr6fKS7bwvcS0P8QDP5fDc4nCew@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Sun, 4 Mar 2018, Dafna Hirschfeld wrote:

> On Sun, Mar 4, 2018 at 9:05 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Sun, 4 Mar 2018, Dafna Hirschfeld wrote:
> >
> >> Fixes of issues found with checkpatch.pl for the lustre obdclass driver.
> >>
> >> Changes in v2:
> >> patch 1:
> >> 1. Revert moving the constant to the right side of comparisons
> >> in order to keep the condition in the form of
> >> 'lower bound <= val && val <= upper bound'
> >>
> >> 2. Revert returning '!!ptr' instead of 'ptr != NULL' since this is
> >> not part of an 'if' statement.
> >>
> >> patches 2+3:
> >> No Change.
> >
> > I think I acked these two.  You should keep the ack in the resubmission.
> >
> > julia
> >
> Hi, you did ack, shell I send another version with your acks ?

Sure.  Thanks.

julia


>
> >>
> >> Dafna Hirschfeld (3):
> >>   staging: lustre: obdclass: Fix comparison to NULL
> >>   staging: lustre: obdclass: Add 'const' to char* array
> >>   staging: lustre: obdclass: Replace 'unsigned' with 'unsigned int'
> >>
> >>  drivers/staging/lustre/lustre/obdclass/cl_lock.c        | 2 +-
> >>  drivers/staging/lustre/lustre/obdclass/cl_object.c      | 2 +-
> >>  drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++--
> >>  drivers/staging/lustre/lustre/obdclass/lu_object.c      | 8 ++++----
> >>  4 files changed, 8 insertions(+), 8 deletions(-)
> >>
> >> --
> >> 2.7.4
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1520153895.git.dafna3%40gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAJ1myNQ4EL6od8MOEh7JpoFUr6fKS7bwvcS0P8QDP5fDc4nCew%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>