Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104;
Date: Tue, 6 Nov 2018 07:45:09 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Ioannis Valasakis <code@wizofe.uk>
cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH] staging: speakup: move comment up to
 reduce 80 chars limit
In-Reply-To: <20181106022504.GA12155@kvasir.local>
Message-ID: <alpine.DEB.2.21.1811060744320.2437@hadrien>
References: <20181106022504.GA12155@kvasir.local>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Tue, 6 Nov 2018, Ioannis Valasakis wrote:

> Move two line comments up in order to reduce the 80 chars exceeding
> limit. Reported by checkpatch.

"in order to avoid exceeding 80 chars" would be a bit clearer.

julia

>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/speakup/spk_priv_keyinfo.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/spk_priv_keyinfo.h b/drivers/staging/speakup/spk_priv_keyinfo.h
> index cc99fcd1bc6e..493f4ebb3473 100644
> --- a/drivers/staging/speakup/spk_priv_keyinfo.h
> +++ b/drivers/staging/speakup/spk_priv_keyinfo.h
> @@ -61,11 +61,13 @@
>  #define SPEAKUP_HELP		0x2d
>  #define TOGGLE_CURSORING	0x2e
>  #define READ_ALL_DOC		0x2f
> -#define SPKUP_MAX_FUNC		0x30 /* one greater than the last func handler */
> +/* one greater than the last func handler */
> +#define SPKUP_MAX_FUNC		0x30
>  #define SPK_KEY		0x80
>  #define FIRST_EDIT_BITS	0x22
>  #define FIRST_SET_VAR SPELL_DELAY
> -#define VAR_START		0x40 /* increase if adding more than 0x3f functions */
> +/* increase if adding more than 0x3f functions */
> +#define VAR_START		0x40
>
>  /* keys for setting variables, must be ordered same as the enum for var_ids */
>  /* with dec being even and inc being 1 greater */
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181106022504.GA12155%40kvasir.local.
> For more options, visit https://groups.google.com/d/optout.
>