From: Julia Lawall Subject: [PATCH] fix odd_ptr_err.cocci warnings Date: Fri, 9 Aug 2019 12:30:46 +0200 (CEST) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Peter Ujfalusi Cc: kbuild-all@01.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org From: kbuild test robot PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 62c9c1442c8f ("j721e new machine driver wip") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip :::::: branch date: 20 hours ago :::::: commit date: 20 hours ago j721e-evm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/soc/ti/j721e-evm.c +++ b/sound/soc/ti/j721e-evm.c @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf parent = devm_clk_get(&pdev->dev, clk_name); kfree(clk_name); if (IS_ERR(parent)) { - ret = PTR_ERR(clocks->parent); + ret = PTR_ERR(parent); if (ret != -EPROBE_DEFER) dev_err(&pdev->dev, "failed to acquire %s': %d\n", prefix, ret); @@ -299,7 +299,7 @@ static int j721e_get_clocks(struct platf parent = devm_clk_get(&pdev->dev, clk_name); kfree(clk_name); if (IS_ERR(parent)) { - ret = PTR_ERR(clocks->parent); + ret = PTR_ERR(parent); if (ret != -EPROBE_DEFER) dev_err(&pdev->dev, "failed to acquire %s': %d\n", prefix, ret);