Content-Type: multipart/mixed; boundary="===============5511506473567031174==" MIME-Version: 1.0 From: Julia Lawall To: kbuild-all@lists.01.org Subject: [staging:staging-testing 50/59] drivers/staging/wfx/hif_tx.c:53:2-8: preceding lock on line 38 (fwd) Date: Fri, 04 Oct 2019 13:18:11 +0200 Message-ID: List-Id: --===============5511506473567031174== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hello, Is an unlock needed on line 53? julia ---------- Forwarded message ---------- Date: Fri, 4 Oct 2019 19:14:33 +0800 From: kbuild test robot To: kbuild(a)01.org Cc: Julia Lawall Subject: [staging:staging-testing 50/59] drivers/staging/wfx/hif_tx.c:53:2-= 8: preceding lock on line 38 CC: kbuild-all(a)01.org CC: devel(a)driverdev.osuosl.org TO: "J=C3=A9r=C3=B4me Pouiller" CC: "Greg Kroah-Hartman" tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git = staging-testing head: 40115bbc40e2fd2de0e01ef2a28e0d09a1b5d0d1 commit: 4f8b7fabb15df3658564a98971fc67029be1815d [50/59] staging: wfx: allo= w to send commands to chip :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago If you fix the issue, kindly add following tag Reported-by: kbuild test robot Reported-by: Julia Lawall >> drivers/staging/wfx/hif_tx.c:53:2-8: preceding lock on line 38 # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit= /?id=3D4f8b7fabb15df3658564a98971fc67029be1815d git remote add staging https://git.kernel.org/pub/scm/linux/kernel/git/greg= kh/staging.git git remote update staging git checkout 4f8b7fabb15df3658564a98971fc67029be1815d vim +53 drivers/staging/wfx/hif_tx.c 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 23 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 24 int wfx_cmd_send(s= truct wfx_dev *wdev, struct hif_msg *request, void *reply, size_t reply_len= , bool async) 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 25 { 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 26 const char *mib_n= ame =3D ""; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 27 const char *mib_s= ep =3D ""; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 28 int cmd =3D reque= st->id; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 29 int vif =3D reque= st->interface; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 30 int ret; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 31 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 32 WARN(wdev->hif_cm= d.buf_recv && wdev->hif_cmd.async, "API usage error"); 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 33 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 34 // Do not wait fo= r any reply if chip is frozen 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 35 if (wdev->chip_fr= ozen) 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 36 return -ETIMEDOU= T; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 37 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 @38 mutex_lock(&wdev-= >hif_cmd.lock); 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 39 WARN(wdev->hif_cm= d.buf_send, "data locking error"); 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 40 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 41 // Note: call to = complete() below has an implicit memory barrier that 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 42 // hopefully prot= ect buf_send 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 43 wdev->hif_cmd.buf= _send =3D request; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 44 wdev->hif_cmd.buf= _recv =3D reply; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 45 wdev->hif_cmd.len= _recv =3D reply_len; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 46 wdev->hif_cmd.asy= nc =3D async; 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 47 complete(&wdev->h= if_cmd.ready); 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 48 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 49 wfx_bh_request_tx= (wdev); 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 50 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 51 // NOTE: no timeo= ut is catched async is enabled 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 52 if (async) 4f8b7fabb15df3 J=C3=A9r=C3=B4me Pouiller 2019-09-19 @53 return 0; --- 0-DAY kernel test infrastructure Open Source Technology Cent= er https://lists.01.org/pipermail/kbuild-all Intel Corporati= on --===============5511506473567031174==--