Content-Type: multipart/mixed; boundary="===============2002937370191371223==" MIME-Version: 1.0 From: Julia Lawall To: kbuild-all@lists.01.org Subject: [PATCH] crypto: fix memdup.cocci warnings Date: Fri, 01 Nov 2019 09:55:34 +0100 Message-ID: List-Id: --===============2002937370191371223== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kbuild test robot Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: f08fcced6d00 ("crypto: allwinner - Add sun8i-ss cryptographic offloa= der") CC: Corentin Labbe Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2= .6.git master head: 298b4c604008025b134bc6fccbc4018449945d60 commit: f08fcced6d0017c39cb6eccb571290867119d049 [154/163] crypto: allwinne= r - Add sun8i-ss cryptographic offloader :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago Please take the patch only if it's a positive warning. Thanks! sun8i-ss-cipher.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c @@ -398,10 +398,9 @@ int sun8i_ss_aes_setkey(struct crypto_sk kfree(op->key); } op->keylen =3D keylen; - op->key =3D kmalloc(keylen, GFP_KERNEL | GFP_DMA); + op->key =3D kmemdup(key, keylen, GFP_KERNEL | GFP_DMA); if (!op->key) return -ENOMEM; - memcpy(op->key, key, keylen); crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK); crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CR= YPTO_TFM_REQ_MASK); @@ -426,10 +425,9 @@ int sun8i_ss_des3_setkey(struct crypto_s kfree(op->key); } op->keylen =3D keylen; - op->key =3D kmalloc(keylen, GFP_KERNEL | GFP_DMA); + op->key =3D kmemdup(key, keylen, GFP_KERNEL | GFP_DMA); if (!op->key) return -ENOMEM; - memcpy(op->key, key, keylen); crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK); crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CR= YPTO_TFM_REQ_MASK); --===============2002937370191371223==--