X-GM-THRID: 6805595890134286336 X-Received: by 2002:a1c:ba06:: with SMTP id k6mr5901580wmf.136.1584551419352; Wed, 18 Mar 2020 10:10:19 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a5d:498c:: with SMTP id r12ls13020044wrq.10.gmail; Wed, 18 Mar 2020 10:10:18 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuYJRJ3y2p3bkNJm55FRRxXfkJZBP0+SOOBcwSr0MyXk6C+ePjCb8FdYpvNnkmnycHOfOMv X-Received: by 2002:adf:fa4c:: with SMTP id y12mr7025923wrr.392.1584551418024; Wed, 18 Mar 2020 10:10:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584551418; cv=none; d=google.com; s=arc-20160816; b=YKnS7pjqYJPQ435RuaRaF4nSM8t6KUcpErNn8KUT/qUq64wRT5xudOrcj+SdsLZBtB QONltso4mvc/yBw11cyKViL0zSNHhOjdRLOzndpYs+Z6hK25IIzxwqiDAV/BjdF5Ap3K 3/Dutchhytwtr9j35qMYC0RW5Bx0eFwEOLK10ymDBE1XDpNkMKewUoNYAgBcwQ1/IoCV 60/+Caz6Kc0rvLgyTllkX3oObX9MWyC4fE3cTNfWQfqD85hdjJVpfCiwzi9tkuYx49qa NvfbDIk/PNb3ud68dBCaH6LUQWbUbNXWr6KrCo8f42hN4noeY8Ze5Z/lsOB4tXlCH40D y48Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date; bh=xv/IH6DzHjSrivqdLkOIhjs3wmb0JPNIX9xQpmnrV3Y=; b=PKTXRX576q8oBwadF6O1fMvLGEWvH3vj7IS7nuIOlyepWeeizWjRgOiLhgKRHIDkzJ ysSoKljcYeg46PcoBtHHvm+2GamsjHrSsoRbBoDSL3iD98FjAhGT/rGTiX6xrEb0u7lx BLUMrEPDgVMfOrTCmS6LxOUHHRRQbv4VBHD6jwcn9dH4PjhxTBhhUPT9XEQhJbwpHYq3 0aYLAUQj3UQWhjbnvBxWpHxJWoGq/3rqnpiiZLdR1zIZTfA1J3Ul8pGd5uJsEoQh1k2c ARc6sreiKNhjT8I92RavSIgtGHEr4rR2cKK1eMdFuuG02oitrn1J6IVCCa8gCn7gNmrR y6Mw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id b81si144568wmc.2.2020.03.18.10.10.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2020 10:10:18 -0700 (PDT) Received-SPF: pass (google.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr X-IronPort-AV: E=Sophos;i="5.70,568,1574118000"; d="scan'208";a="342835055" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 18:10:17 +0100 Date: Wed, 18 Mar 2020 18:10:17 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Sam Muhammed cc: outreachy-kernel@googlegroups.com, Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Greg Kroah-Hartman Subject: Re: [Outreachy kernel] [PATCH] Staging: qlge: Add blank line after variable declarations. In-Reply-To: <20200318170713.3886-1-jane.pnx9@gmail.com> Message-ID: References: <20200318170713.3886-1-jane.pnx9@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 18 Mar 2020, Sam Muhammed wrote: > Cleanup checkpatch.pl WARNING: Missing a blank line after declarations. > > Signed-off-by: Sam Muhammed > --- > drivers/staging/qlge/qlge_dbg.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c > index 737d6abd8076..8bf592812518 100644 > --- a/drivers/staging/qlge/qlge_dbg.c > +++ b/drivers/staging/qlge/qlge_dbg.c > @@ -496,7 +496,9 @@ static int ql_get_mpi_shadow_regs(struct ql_adapter *qdev, u32 *buf) > static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, > u32 offset, u32 count) > { > - int i, status = 0; > + int i; > + int status = 0; > + This does more than add a blank line. Actually, it's fine to declare several variables at once. julia > for (i = 0; i < count; i++, buf++) { > status = ql_read_mpi_reg(qdev, offset + i, buf); > if (status) > @@ -1330,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) > { > int i; > u32 value; > + > for (i = 0; i < qdev->intr_count; i++) { > ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask); > value = ql_read32(qdev, INTR_EN); > @@ -1415,6 +1418,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) > { > int i; > u32 value; > + > i = ql_sem_spinlock(qdev, SEM_RT_IDX_MASK); > if (i) > return; > @@ -1565,6 +1569,7 @@ void ql_dump_stat(struct ql_adapter *qdev) > void ql_dump_qdev(struct ql_adapter *qdev) > { > int i; > + > DUMP_QDEV_FIELD(qdev, "%lx", flags); > DUMP_QDEV_FIELD(qdev, "%p", vlgrp); > DUMP_QDEV_FIELD(qdev, "%p", pdev); > @@ -1650,6 +1655,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring) > void ql_dump_ricb(struct ricb *ricb) > { > int i; > + > pr_err("===================== Dumping ricb ===============\n"); > pr_err("Dumping ricb stuff...\n"); > > -- > 2.20.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200318170713.3886-1-jane.pnx9%40gmail.com. >