Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E426C10DCE for ; Wed, 18 Mar 2020 17:45:19 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DF1C20752 for ; Wed, 18 Mar 2020 17:45:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DF1C20752 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3873887F6F; Wed, 18 Mar 2020 17:45:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AQ4jGyXIvrRD; Wed, 18 Mar 2020 17:45:17 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 36D8787F34; Wed, 18 Mar 2020 17:45:17 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 220E0C07FE; Wed, 18 Mar 2020 17:45:17 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id E5CDEC013E for ; Wed, 18 Mar 2020 17:45:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E22C3886DF for ; Wed, 18 Mar 2020 17:45:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XP5Z1MWxb0SN for ; Wed, 18 Mar 2020 17:45:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by hemlock.osuosl.org (Postfix) with ESMTPS id 71BB4886C3 for ; Wed, 18 Mar 2020 17:45:14 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.70,568,1574118000"; d="scan'208";a="342839951" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 18:45:12 +0100 Date: Wed, 18 Mar 2020 18:45:12 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Jaskaran Singh In-Reply-To: <20200317084310.12652-1-jaskaransingh7654321@gmail.com> Message-ID: References: <20200316100319.27935-6-jaskaransingh7654321@gmail.com> <20200317084310.12652-1-jaskaransingh7654321@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Linux-kernel-mentees] [PATCH v2 05/26] parsing_cocci: visitor_ast: Add cases for ParenType/FunctionType X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Tue, 17 Mar 2020, Jaskaran Singh wrote: > The order of the terms in ParenType require implementing a special > case for ParenType. This case handles only the following: > > ( * id [ .* ] ) ( params ) > > i.e., a function pointer or an array of function pointers, and will fail > for any other cases. This is similar to the function used to print > ParenType in Pretty_print_c. > > Signed-off-by: Jaskaran Singh > --- > Changes in v2: > ------------- > - Change the "visitor_ast0" in patch subject to "visitor_ast" > > parsing_cocci/visitor_ast.ml | 75 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > > diff --git a/parsing_cocci/visitor_ast.ml b/parsing_cocci/visitor_ast.ml > index 3d5de794..99af7652 100644 > --- a/parsing_cocci/visitor_ast.ml > +++ b/parsing_cocci/visitor_ast.ml > @@ -318,6 +318,61 @@ let combiner bind option_default > let lrb = string_mcode rb in > multibind ([lty] @ lid @ [lb; lsize; lrb]) > > + and parentype_type (lp, ty, (id : Ast.ident option), rp) = > + match Ast.unwrap ty with > + Ast.Type(_,_,fty1) -> > + (match Ast.unwrap fty1 with > + Ast.Pointer(ty1,star) -> > + (match Ast.unwrap ty1 with > + Ast.Type(_,_,fty2) -> > + (match Ast.unwrap fty2 with > + Ast.FunctionType(ty2,lp2,params,rp2) -> > + let typ = fullType ty2 in > + let lp = string_mcode lp in > + let star = string_mcode star in > + let idl = match id with > + | Some idd -> [ident idd] > + | None -> [] in > + let rp = string_mcode rp in > + let lp2 = string_mcode lp2 in > + let params = parameter_dots params in > + let rp2 = string_mcode rp2 in > + multibind > + ([typ;lp;star] @ idl @ [rp;lp2;params;rp2]) > + | _ -> failwith "ParenType Visitor_ast") > + | _ -> failwith "ParenType Visitor_ast") > + | Ast.Array(ty1,lb1,size1,rb1) -> > + (match Ast.unwrap ty1 with > + Ast.Type(_,_,fty2) -> > + (match Ast.unwrap fty2 with > + Ast.Pointer(ty2,star) -> > + (match Ast.unwrap ty2 with > + Ast.Type(_,_,fty3) -> > + (match Ast.unwrap fty3 with > + Ast.FunctionType(ty3,lp3,params,rp3) -> > + let typ = fullType ty3 in > + let lp = string_mcode lp in > + let star = string_mcode star in > + let idl = match id with > + | Some idd -> [ident idd] > + | None -> [] in > + let lb1 = string_mcode lb1 in > + let size1 = get_option expression size1 in > + let rb1 = string_mcode rb1 in > + let rp = string_mcode rp in > + let lp3 = string_mcode lp3 in > + let params = parameter_dots params in > + let rp3 = string_mcode rp3 in > + multibind > + ([typ;lp;star] @ idl @ > + [lb1;size1;rb1;rp;lp3;params;rp3]) > + | _ -> failwith "ParenType Visitor_ast") > + | _ -> failwith "ParenType Visitor_ast") > + | _ -> failwith "ParenType Visitor_ast") > + | _ -> failwith "ParenType Visitor_ast") > + | _ -> failwith "ParenType Visitor_ast") > + | _ -> failwith "ParenType Visitor_ast" Same comments as in the ast0 case: the match can go on a line below and I wonder if some of the code can be shared. julia > + > and typeC ty = > let k ty = > match Ast.unwrap ty with > @@ -332,6 +387,14 @@ let combiner bind option_default > bind lty lstar > | Ast.FunctionPointer(ty,lp1,star,rp1,lp2,params,rp2) -> > function_pointer (ty,lp1,star,None,rp1,lp2,params,rp2) > + | Ast.ParenType(lp,ty,rp) -> > + parentype_type (lp,ty,None,rp) > + | Ast.FunctionType(ty,lp,params,rp) -> > + let lty = fullType ty in > + let llp = string_mcode lp in > + let lparams = parameter_dots params in > + let lrp = string_mcode rp in > + multibind [lty; llp; lparams; lrp] > | Ast.Array(ty,lb,size,rb) -> array_type (ty,None,lb,size,rb) > | Ast.Decimal(dec,lp,length,comma,precision_opt,rp) -> > let ldec = string_mcode dec in > @@ -384,6 +447,7 @@ let combiner bind option_default > Ast.FunctionPointer(ty,lp1,star,rp1,lp2,params,rp2) -> > function_pointer (ty, lp1, star, Some id, rp1, lp2, params, rp2) > | Ast.Array(ty,lb,size,rb) -> array_type (ty, Some id, lb, size, rb) > + | Ast.ParenType(lp,ty,rp) -> parentype_type (lp, ty, Some id, rp) > | _ -> let lty = fullType ty in > let lid = ident id in > bind lty lid) > @@ -1253,6 +1317,17 @@ let rebuilder > let lparams = parameter_dots params in > let lrp2 = string_mcode rp2 in > Ast.FunctionPointer(lty, llp1, lstar, lrp1, llp2, lparams, lrp2) > + | Ast.ParenType(lp,ty,rp) -> > + let llp = string_mcode lp in > + let lty = fullType ty in > + let lrp = string_mcode rp in > + Ast.ParenType(llp,lty,lrp) > + | Ast.FunctionType(ty,lp,params,rp) -> > + let lty = fullType ty in > + let llp = string_mcode lp in > + let lparams = parameter_dots params in > + let lrp = string_mcode rp in > + Ast.FunctionType(lty,llp,lparams,lrp) > | Ast.Array(ty,lb,size,rb) -> > let lty = fullType ty in > let llb = string_mcode lb in > -- > 2.21.1 > > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees