Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53A08C54FCB for ; Mon, 27 Apr 2020 17:00:38 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07EEC206B9 for ; Mon, 27 Apr 2020 17:00:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07EEC206B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id DF74387EBB; Mon, 27 Apr 2020 17:00:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nNSK1h0I2JaH; Mon, 27 Apr 2020 17:00:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 3B58D87EB8; Mon, 27 Apr 2020 17:00:37 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2D3DDC1D74; Mon, 27 Apr 2020 17:00:37 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id EFCE9C0172 for ; Mon, 27 Apr 2020 17:00:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E491085F92 for ; Mon, 27 Apr 2020 17:00:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m9Z9v4u3xahS for ; Mon, 27 Apr 2020 17:00:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 98AF485F89 for ; Mon, 27 Apr 2020 17:00:32 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.73,324,1583190000"; d="scan'208";a="347097522" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2020 19:00:22 +0200 Date: Mon, 27 Apr 2020 19:00:22 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Jaskaran Singh In-Reply-To: <20200427120834.380-6-jaskaransingh7654321@gmail.com> Message-ID: References: <20200427120834.380-1-jaskaransingh7654321@gmail.com> <20200427120834.380-6-jaskaransingh7654321@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Linux-kernel-mentees] [PATCH 05/23] parsing_cocci: check_meta: Reflect Parameter attributes X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, 27 Apr 2020, Jaskaran Singh wrote: > Parameter attributes are added to the SmPL AST. Reflect these changes in > check_meta.ml. Maybe add a comment that for the moment there are no metavariables for attributes. julia > > Signed-off-by: Jaskaran Singh > --- > parsing_cocci/check_meta.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/parsing_cocci/check_meta.ml b/parsing_cocci/check_meta.ml > index 5a348ba3..ab1d357e 100644 > --- a/parsing_cocci/check_meta.ml > +++ b/parsing_cocci/check_meta.ml > @@ -374,7 +374,7 @@ and initialiser_list old_metas table minus = > > and parameterTypeDef old_metas table minus param = > match Ast0.unwrap param with > - Ast0.Param(ty,id) -> > + Ast0.Param(ty,id,attr) -> > get_opt (ident ID old_metas table minus) id; > typeC old_metas table minus ty > | Ast0.MetaParam(name,_,_) -> > -- > 2.21.1 > > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees