Content-Type: multipart/mixed; boundary="===============5485980358939432873==" MIME-Version: 1.0 From: Julia Lawall To: kbuild-all@lists.01.org Subject: Re: [EXTERNAL] fs/cifs/transport.c:1284:2-8: preceding lock on line 1277 (fwd) Date: Thu, 18 Jun 2020 20:12:12 +0200 Message-ID: In-Reply-To: List-Id: --===============5485980358939432873== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, 18 Jun 2020, Steven French wrote: > Wasn't this fixed last year by: It looks like it. I received the message today from kbuild, but I didn't look further than that. Perhaps it is an old tree somehow. julia > > commit 8bd3754cff3aa6e80e73cb56042cdc6f76d6510e > Author: Dan Carpenter > Date: =C2=A0 Fri Oct 25 13:35:08 2019 +0300 > > =C2=A0 =C2=A0 cifs: rename a variable in SendReceive() > =C2=A0 =C2=A0 > =C2=A0 =C2=A0 Smatch gets confused because we sometimes refer to "server-= >srv_mutex" > and > =C2=A0 =C2=A0 sometimes to "sess->server->srv_mutex". =C2=A0They refer to= the same lock so > =C2=A0 =C2=A0 let's just make this consistent. > =C2=A0 =C2=A0 > =C2=A0 =C2=A0 Signed-off-by: Dan Carpenter > =C2=A0 =C2=A0 Signed-off-by: Steve French > > diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c > index ca3de62688d6..f27842fb9f75 100644 > --- a/fs/cifs/transport.c > +++ b/fs/cifs/transport.c > @@ -1287,7 +1287,7 @@ SendReceive(const unsigned int xid, struct cifs_ses > *ses, > =C2=A0 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 rc =3D allocate_mid(ses, in_buf, &midQ); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (rc) { > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mutex_unlock(&ses->ser= ver->srv_mutex); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mutex_unlock(&server->= srv_mutex); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Update # of re= quests on wire to server */ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 add_credits(serve= r, &credits, 0); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return rc; > > _________________________________________________________________________= ___ > From: Julia Lawall > Sent: Thursday, June 18, 2020 10:08 AM > To: Ronnie Sahlberg > Cc: Steven French ; > linux-kernel(a)vger.kernel.org ; > kbuild-all(a)lists.01.org > Subject: [EXTERNAL] fs/cifs/transport.c:1284:2-8: preceding lock on line > 1277 (fwd) =C2=A0 > Hello, > > This is not actually a bug.=C2=A0 But for both tools and humans, it might= be > better to refer to the lock on line 1281 in the same way that it is > referred to on line 1277. > > julia > > ---------- Forwarded message ---------- > Date: Thu, 18 Jun 2020 08:07:12 +0800 > From: kernel test robot > To: kbuild(a)lists.01.org > Cc: lkp(a)intel.com, Julia Lawall > Subject: fs/cifs/transport.c:1284:2-8: preceding lock on line 1277 > > CC: kbuild-all(a)lists.01.org > CC: linux-kernel(a)vger.kernel.org > TO: Ronnie Sahlberg > CC: Steve French > > tree:=C2=A0=C2=A0https://nam06.safelinks.protection.outlook.com/?url=3Dht= tps%3A%2F%2Fgit.kerne > l.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&data= =3D0 > 2%7C01%7CSteven.French%40microsoft.com%7C206f157b15804da9dad408d81399862d% > 7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637280897690591644&sdata= =3D > rglSnjoPRmT8g0Fj9k2jeCz11jZmXeUmB8W5vnD3LO4%3D&reserved=3D0 master > head:=C2=A0=C2=A0 1b5044021070efa3259f3e9548dc35d1eb6aa844 > commit: afe6f65353b644f55875d42d812ffe87f1887d68 cifs: add new debugging > macro cifs_server_dbg > date:=C2=A0=C2=A0 9 months ago > :::::: branch date: 6 hours ago > :::::: commit date: 9 months ago > config: xtensa-randconfig-c024-20200617 (attached as .config) > compiler: xtensa-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Julia Lawall > > > coccinelle warnings: (new ones prefixed by >>) > > >> fs/cifs/transport.c:1284:2-8: preceding lock on line 1277 > > #https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit.= kerne > l.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2 > F%3Fid%3Dafe6f65353b644f55875d42d812ffe87f1887d68&data=3D02%7C01%7CSt= eve > n.French%40microsoft.com%7C206f157b15804da9dad408d81399862d%7C72f988bf86f1 > 41af91ab2d7cd011db47%7C1%7C0%7C637280897690591644&sdata=3DAeeIaHJgLjC= ns9 > aksXdMxnYone5UZVM3n2DREKL6N6c%3D&reserved=3D0 > git remote add linushttps://nam06.safelinks.protection.outlook.com/?url= =3Dhttps%3A%2F%2Fgit.kerne > l.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&data= =3D0 > 2%7C01%7CSteven.French%40microsoft.com%7C206f157b15804da9dad408d81399862d% > 7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637280897690601647&sdata= =3D > K6zcUzaXsw9IkszPgZX66llW8857a9ApKU9e2Z9rDFY%3D&reserved=3D0 > git remote update linus > git checkout afe6f65353b644f55875d42d812ffe87f1887d68 > vim +1284 fs/cifs/transport.c > > 738f9de5cdb917 Pavel Shilovsky 2016-11-23=C2=A0 1233 > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1234=C2=A0 int > 96daf2b09178d8 Steve French=C2=A0=C2=A0=C2=A0 2011-05-27=C2=A0 1235=C2=A0= SendReceive(const unsigned > int xid, struct cifs_ses *ses, > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1236=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct smb_= hdr > *in_buf, struct smb_hdr *out_buf, > 480b1cb9dad894 Ronnie Sahlberg 2019-03-08=C2=A0 1237=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int > *pbytes_returned, const int flags) > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1238=C2=A0 { > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1239=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int rc =3D 0; > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1240=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct mid_q_entry > *midQ; > fb2036d817584d Pavel Shilovsky 2016-11-23=C2=A0 1241=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int len =3D > be32_to_cpu(in_buf->smb_buf_length); > fb2036d817584d Pavel Shilovsky 2016-11-23=C2=A0 1242=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct kvec iov =3D { > .iov_base =3D in_buf, .iov_len =3D len }; > fb2036d817584d Pavel Shilovsky 2016-11-23=C2=A0 1243=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct smb_rqst > rqst =3D { .rq_iov =3D &iov, .rq_nvec =3D 1 }; > 34f4deb7c56c6f Pavel Shilovsky 2019-01-16=C2=A0 1244=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct cifs_credits > credits =3D { .value =3D 1, .instance =3D 0 }; > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1245=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct > TCP_Server_Info *server =3D ses->server; > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1246 > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1247=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (ses =3D=3D NULL) { > f96637be081141 Joe Perches=C2=A0=C2=A0=C2=A0=C2=A0 2013-05-04=C2=A0 1248= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 > cifs_dbg(VFS, "Null smb session\n"); > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1249=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 return > -EIO; > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1250=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1251=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (server =3D=3D NULL) > { > f96637be081141 Joe Perches=C2=A0=C2=A0=C2=A0=C2=A0 2013-05-04=C2=A0 1252= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 > cifs_dbg(VFS, "Null tcp session\n"); > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1253=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 return > -EIO; > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1254=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1255 > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1256=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if > (server->tcpStatus =3D=3D CifsExiting) > 31ca3bc3c569f9 Steve French=C2=A0=C2=A0=C2=A0 2005-04-28=C2=A0 1257=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 return > -ENOENT; > 31ca3bc3c569f9 Steve French=C2=A0=C2=A0=C2=A0 2005-04-28=C2=A0 1258 > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1259=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Ensure that we > do not send more than 50 overlapping requests > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1260=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 to the same > server. We may make this configurable later or > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1261=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 use ses->maxReq > */ > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1262 > fb2036d817584d Pavel Shilovsky 2016-11-23=C2=A0 1263=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (len > > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE - 4) { > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1264=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > cifs_server_dbg(VFS, "Illegal length, greater than maximum frame, %d\n", > fb2036d817584d Pavel Shilovsky 2016-11-23=C2=A0 1265=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > len); > 6d9c6d543165d1 Volker Lendecke 2008-12-08=C2=A0 1266=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 return > -EIO; > 6d9c6d543165d1 Volker Lendecke 2008-12-08=C2=A0 1267=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > 6d9c6d543165d1 Volker Lendecke 2008-12-08=C2=A0 1268 > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1269=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D > wait_for_free_request(server, flags, &credits.instance); > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1270=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rc) > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1271=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 return rc; > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1272 > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1273=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* make sure that > we sign in the same order that we send on this socket > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1274=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 and avoid races > inside tcp sendmsg code that could cause corruption > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1275=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 of smb data */ > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1276 > afe6f65353b644 Ronnie Sahlberg 2019-08-28 @1277=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > mutex_lock(&server->srv_mutex); > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1278 > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1279=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D > allocate_mid(ses, in_buf, &midQ); > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1280=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rc) { > 72ca545b2d83ac Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2008-12-01=C2=A0 1281= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 > mutex_unlock(&ses->server->srv_mutex); > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1282=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 /* Update # > of requests on wire to server */ > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1283=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > add_credits(server, &credits, 0); > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02 @1284=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 return rc; > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1285=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1286 > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1287=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D > cifs_sign_smb(in_buf, server, &midQ->sequence_number); > 829049cbb1d2dd Volker Lendecke 2008-12-06=C2=A0 1288=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rc) { > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1289=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > mutex_unlock(&server->srv_mutex); > 829049cbb1d2dd Volker Lendecke 2008-12-06=C2=A0 1290=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 goto out; > 829049cbb1d2dd Volker Lendecke 2008-12-06=C2=A0 1291=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > ^1da177e4c3f41 Linus Torvalds=C2=A0 2005-04-16=C2=A0 1292 > 7c9421e1a9ce8d Pavel Shilovsky 2012-03-23=C2=A0 1293=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 midQ->mid_state =3D > MID_REQUEST_SUBMITTED; > 789e66612367f9 Steve French=C2=A0=C2=A0=C2=A0 2011-08-09=C2=A0 1294 > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1295=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > cifs_in_send_inc(server); > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1296=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D > smb_send(server, in_buf, len); > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1297=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > cifs_in_send_dec(server); > 789e66612367f9 Steve French=C2=A0=C2=A0=C2=A0 2011-08-09=C2=A0 1298=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > cifs_save_when_sent(midQ); > ad313cb86dfba2 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2013-04-03=C2=A0 1299 > ad313cb86dfba2 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2013-04-03=C2=A0 1300= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rc < 0) > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1301=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > server->sequence_number -=3D 2; > ad313cb86dfba2 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2013-04-03=C2=A0 1302 > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1303=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > mutex_unlock(&server->srv_mutex); > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1304 > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1305=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rc < 0) > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1306=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 goto out; > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1307 > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1308=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D > wait_for_response(server, midQ); > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1309= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rc !=3D 0) { > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1310=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > send_cancel(server, &rqst, midQ); > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1311= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 > spin_lock(&GlobalMid_Lock); > 7c9421e1a9ce8d Pavel Shilovsky 2012-03-23=C2=A0 1312=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if > (midQ->mid_state =3D=3D MID_REQUEST_SUBMITTED) { > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1313= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= /* > no longer considered to be "in-flight" */ > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1314= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > midQ->callback =3D DeleteMidQEntry; > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1315= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > spin_unlock(&GlobalMid_Lock); > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1316=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > add_credits(server, &credits, 0); > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1317= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > return rc; > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1318= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 } > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1319= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 > spin_unlock(&GlobalMid_Lock); > 1be912dde772b7 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-28=C2=A0 1320= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > 14a441a2b4ee1d Steve French=C2=A0=C2=A0=C2=A0 2006-07-16=C2=A0 1321 > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1322=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D > cifs_sync_mid_result(midQ, server); > 053d50344568e5 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-01-11=C2=A0 1323= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rc !=3D 0) { > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1324=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > add_credits(server, &credits, 0); > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1325=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 return rc; > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1326=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1327 > 2c8f981d93f830 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-05-19=C2=A0 1328= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!midQ->resp_buf > || !out_buf || > 7c9421e1a9ce8d Pavel Shilovsky 2012-03-23=C2=A0 1329=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 midQ->mid_state > !=3D MID_RESPONSE_RECEIVED) { > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1330=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 rc =3D -EIO; > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1331=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > cifs_server_dbg(VFS, "Bad MID state?\n"); > 2c8f981d93f830 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-05-19=C2=A0 1332= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 goto out; > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1333=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1334 > d4e4854fd1c85a Pavel Shilovsky 2012-03-23=C2=A0 1335=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *pbytes_returned =3D > get_rfc1002_length(midQ->resp_buf); > 2c8f981d93f830 Jeff Layton=C2=A0=C2=A0=C2=A0=C2=A0 2011-05-19=C2=A0 1336= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 memcpy(out_buf, > midQ->resp_buf, *pbytes_returned + 4); > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1337=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rc =3D > cifs_check_receive(midQ, server, 0); > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1338=C2=A0 out: > 3c1bf7e48e9e46 Pavel Shilovsky 2012-09-18=C2=A0 1339=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > cifs_delete_mid(midQ); > afe6f65353b644 Ronnie Sahlberg 2019-08-28=C2=A0 1340=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 add_credits(server, > &credits, 0); > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1341 > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1342=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return rc; > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1343=C2=A0 } > 7ee1af765dfa31 Jeremy Allison=C2=A0 2006-08-02=C2=A0 1344 > > :::::: The code at line 1284 was first introduced by commit > :::::: 7ee1af765dfa3146aef958258003245e082284e5 [CIFS] > > :::::: TO: Jeremy Allison > :::::: CC: Steve French > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists= .01. > org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=3D02%7C01%7C= Ste > ven.French%40microsoft.com%7C206f157b15804da9dad408d81399862d%7C72f988bf86 > f141af91ab2d7cd011db47%7C1%7C0%7C637280897690601647&sdata=3D8ooAqMhFs= u0W > PNZHTqniPgiydgShTnlvnHtQMieY3Ao%3D&reserved=3D0 > > --===============5485980358939432873==--