Content-Type: multipart/mixed; boundary="===============0661092711483494037==" MIME-Version: 1.0 From: Julia Lawall To: kbuild-all@lists.01.org Subject: [PATCH] selinux: fix memdup.cocci warnings Date: Thu, 20 Aug 2020 12:20:51 +0200 Message-ID: List-Id: --===============0661092711483494037== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: c7c556f1e81b ("selinux: refactor changing booleans") CC: Stephen Smalley Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git= next head: 37ea433c66070fcef09c6d118492c36299eb72ba commit: c7c556f1e81bb9e09656ed6650d0c44c84b7c016 [4/6] selinux: refactor ch= anging booleans :::::: branch date: 4 hours ago :::::: commit date: 2 days ago conditional.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/security/selinux/ss/conditional.c +++ b/security/selinux/ss/conditional.c @@ -686,12 +686,11 @@ static int cond_bools_copy(struct hashta { struct cond_bool_datum *datum; - datum =3D kmalloc(sizeof(struct cond_bool_datum), GFP_KERNEL); + datum =3D kmemdup(orig->datum, sizeof(struct cond_bool_datum), + GFP_KERNEL); if (!datum) return -ENOMEM; - memcpy(datum, orig->datum, sizeof(struct cond_bool_datum)); - new->key =3D orig->key; /* No need to copy, never modified */ new->datum =3D datum; return 0; --===============0661092711483494037==--