Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:59842 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753697AbZGEOUR (ORCPT ); Sun, 5 Jul 2009 10:20:17 -0400 Date: Sun, 5 Jul 2009 07:19:33 -0700 (PDT) From: Linus Torvalds To: Wu Zhangjin cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Krzysztof Helt , Peter Zijlstra , "Rafael J. Wysocki" , Andrew Morton , Ralf Baechle , =?GB2312?B?6sy7qg==?= , zhangfx Subject: Re: [BUG] drivers/video/sis: deadlock introduced by "fbdev: add mutex for fb_mmap locking" In-Reply-To: <1246785112.14240.34.camel@falcon> Message-ID: References: <1246785112.14240.34.camel@falcon> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-media-owner@vger.kernel.org List-ID: On Sun, 5 Jul 2009, Wu Zhangjin wrote: > > then it works! so, I guess there is a deadlock introduced by the above > commit. Hmm. Perhaps more likely, the 'mm_lock' mutex hasn't even been initialized yet. We appear to have had that problem with matroxfb and sm501fb, and it may be more common than that. See commit f50bf2b2. That said, I do agree that the mm_lock seems to be causing more problems than it actually fixes, and maybe we should revert it. Krzysztof? Linus