From: Linus Torvalds Date: Tue, 15 Sep 2009 21:20:47 -0700 (PDT) Subject: [Ocfs2-devel] [GIT PULL] ocfs2 changes for 2.6.32 In-Reply-To: <20090915214530.GA11060@mail.oracle.com> References: <20090911200458.GA15416@mail.oracle.com> <20090914221434.GA4507@mail.oracle.com> <20090915000417.GC4507@mail.oracle.com> <20090915005417.GD4507@mail.oracle.com> <20090915040601.GE4507@mail.oracle.com> <20090915214530.GA11060@mail.oracle.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joel Becker Cc: Mark Fasheh , Andrew Morton , Linux Kernel Mailing List , ocfs2-devel@oss.oracle.com On Tue, 15 Sep 2009, Joel Becker wrote: > > Perhaps ->copyfile takes the following flags: > > #define ALLOW_COW_SHARED 0x0001 > #define REQUIRE_COW_SHARED 0x0002 > #define REQUIRE_BASIC_ATTRS 0x0004 > #define REQUIRE_FULL_ATTRS 0x0008 > #define REQUIRE_ATOMIC 0x0010 > #define SNAPSHOT (REQUIRE_COW_SHARED | > REQUIRE_BASIC_ATTRS | > REQUIRE_ATOMIC) > #define SNAPSHOT_PRESERVE (SNAPSHOT | REQUIRE_FULL_ATTRS) > > Thus, sys_reflink/sys_snapfile(oldpath, newpath, 0) becomes: > ... Yes. The above all sounds sane to me. I still worry that especially the non-atomic case will want some kind of partial-copy updates (think graphical file managers that want to show the progress of the copy), and that (think EINTR and continuing) makes me think "that could get really complex really quickly", but that's something that the NFS/SMB people would have to pipe up on. I'm pretty sure the NFS spec has some kind "partial completion notification" model, I dunno about SMB. Linus