Reply-To: kernel-hardening@lists.openwall.com Date: Tue, 9 Apr 2013 00:42:49 +0100 (BST) From: "Maciej W. Rozycki" In-Reply-To: Message-ID: References: <20130408224328.GA17641@www.outflux.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: [kernel-hardening] Re: [PATCH] x86: make IDT read-only To: Kees Cook Cc: Ingo Molnar , LKML , Thomas Gleixner , "H. Peter Anvin" , "x86@kernel.org" , Konrad Rzeszutek Wilk , Jeremy Fitzhardinge , Marcelo Tosatti , Alex Shi , Borislav Petkov , Alexander Duyck , Frederic Weisbecker , Steven Rostedt , "Paul E. McKenney" , "xen-devel@lists.xensource.com" , "virtualization@lists.linux-foundation.org" , "kernel-hardening@lists.openwall.com" , Dan Rosenberg , Julien Tinnes , Will Drewry , Eric Northup List-ID: On Mon, 8 Apr 2013, Kees Cook wrote: > > FWIW the change looks reasonable to me, however given that that it makes > > the arrangement unconditional and there is no longer a workaround to > > enable I think it would make sense to remove the conditional block quoted > > above altogether, along with the f00f_workaround_enabled variable itself > > (alternatively "Intel Pentium with F0 0F bug" alone could be printed > > instead and the name of the variable adjusted to make sense with the new > > meaning -- up to you to decide). > > Actually, I take it back. The other portion of the workaround is still > active (in mm/fault.c), and this chunk announces it, so I'm going to > leave it as-is. Ah, OK then. Thanks for double-checking. Maciej