From: "Robert P. J. Day" Subject: Re: any reason for include/uapi/sound header files not listed in Kbuild? Date: Tue, 31 May 2016 08:54:29 -0400 (EDT) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp484.redcondor.net (smtp484.redcondor.net [208.80.204.84]) by alsa0.perex.cz (Postfix) with ESMTP id 1B58026052B for ; Tue, 31 May 2016 14:55:17 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, 31 May 2016, Takashi Iwai wrote: > On Sat, 28 May 2016 21:10:32 +0200, > Robert P. J. Day wrote: > > > > > > i just noticed that, in include/uapi/sound/, there are three header > > files: > > > > * asoc.h > > * tlv.h > > * usb_stream.h > > > > that are not referenced by the corresponding Kbuild file. is there any > > reason for this? > > There is no reason. I noticed this sometime ago but forgot after > that. > > > or, in general, is there *any* reason for there to be > > header files under include/uapi/ that are not listed in their Kbuild > > files? thanks. > > Yes, they should be included in Kbuild file. So far, all user-space > stuff is self-contained, keeping the copy of such files in it, thus > there was no complaint due to the missing files. > > That said, feel free to send a fix patch ;) so the patch would be to include the missing files in Kbuild, not to delete them? :-) rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================