Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DATE_IN_PAST_12_24, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1D6C433DF for ; Wed, 13 May 2020 22:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E904020659 for ; Wed, 13 May 2020 22:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731690AbgEMWzH (ORCPT ); Wed, 13 May 2020 18:55:07 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:28323 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731276AbgEMWzH (ORCPT ); Wed, 13 May 2020 18:55:07 -0400 IronPort-SDR: dxK+kVruO6R7RzTbFz8FhMQNlLMG2DNSQgr8xk1vrYGHuVKOEKizgwgiJqA24gE5stI2LTAShZ eSEWPRNOVz8yB1gPWBDFZOVi2/7OA0dBALodQihKS7AIBg1MDDIofLF7bMHVd2IITtc/NvbvK2 /5ocJFjyIa9l/cT0b7ISkanckDjbaZqRCt+jYONcxchfibChof1J/T/XPIcJonDFLKpkE9dmbw x4SDHuyIQG9WwIoT2poXHvO8N0jKJ13391BX3gKmoXdt2kbNv8EE+53FzaBje/osIlDZuyKPFo ZaQ= X-IronPort-AV: E=Sophos;i="5.73,389,1583164800"; d="scan'208";a="137958561" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 14 May 2020 06:55:07 +0800 IronPort-SDR: v2It7tWcty9NvlnDZ9sfk6nVZyG0FhiNPnqP/OTWNfjIXjOe+2VuUBhsWj8pRrCQBRZpv1fTSs M6jci1+TnwofBT9enP5f+Z7hqT/Llwbsk= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 15:44:46 -0700 IronPort-SDR: jlZ5A1kriLxb8dNClmXUI2YsaQQqlTCvZUVo3fj6doq0sXhvX/zkMW6mx2hGkv+0/zw8FAXdDl sLnzsUP/Taeg== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 15:55:06 -0700 Date: Wed, 13 May 2020 00:52:50 +0100 (BST) From: "Maciej W. Rozycki" To: Thomas Bogendoerfer cc: Huacai Chen , "open list:MIPS" , Fuxin Zhang , Zhangjin Wu , Jiaxun Yang Subject: Re: [PATCH] MIPS: inst.h: Stop including asm.h to avoid various build failures In-Reply-To: <20200509152501.GA9125@alpha.franken.de> Message-ID: References: <1588930212-5255-1-git-send-email-chenhc@lemote.com> <20200508130149.GA14297@alpha.franken.de> <20200509152501.GA9125@alpha.franken.de> Content-Type: text/plain; charset=US-ASCII X-ReSent-Date: Wed, 13 May 2020 23:45:46 +0100 (BST) X-ReSent-From: "Maciej W. Rozycki" X-ReSent-To: "Maciej W. Rozycki" X-ReSent-Subject: Re: [PATCH] MIPS: inst.h: Stop including asm.h to avoid various build failures X-ReSent-Message-ID: MIME-Version: 1.0 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, 9 May 2020, Thomas Bogendoerfer wrote: > > > > Commit d339cd02b888eb8 ("MIPS: Move unaligned load/store helpers to > > > > inst.h") causes a lot of build failures because macros in asm.h conflict > > > > with various subsystems. Some of these conflictions has been fixed (such > > > > as LONG, PANIC and PRINT) by adjusting asm.h, but some of them is nearly > > > > impossible to fix (such as PTR and END). The only reason of including > > > > asm.h in inst.h is that we need the PTR macro which is used by unaligned > > > > load/store helpers. So in this patch we define a new PTR_STR macro and > > > > use it to replace STR(PTR), then we can stop including asm.h to avoid > > > > various build failures. > > > > > > > > Fixes: d339cd02b888eb8 ("MIPS: Move unaligned load/store helpers to inst.h") > > > > Reported-by: kbuild test robot > > > > Signed-off-by: Huacai Chen > > > > --- > > > > arch/mips/include/asm/inst.h | 184 ++++++++++++++++++++++--------------------- > > > > > > applied to mips-next. /me hopes this is the last fix... thanks > > I think this is the last fix... and, does "MIPS: asm: Rename some > > macros to avoid build errors" need to be reverted? > > let's keep it as it is now. Sigh, this just shows how the original change was wrong in the first place. Why was specifically chosen, whose purpose has been machine code generators/interpreters that has nothing to do with unaligned access helpers, over a more suitable location, such as (maybe obviously?) ? I suggest that we roll back to before the destruction, move the necessary bits away from , and then perhaps none of the follow-up hacks will be required. Maciej