Received: from cpanel7.indieserve.net (cpanel7.indieserve.net [199.212.143.8]) by mx.groups.io with SMTP id smtpd.web12.3212.1590574500301483811 for ; Wed, 27 May 2020 03:15:00 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: crashcourse.ca, ip: 199.212.143.8, mailfrom: rpjday@crashcourse.ca) Received: from cpeac202e043973-cmac202e043970.sdns.net.rogers.com ([174.114.100.179]:43814 helo=localhost.localdomain) by cpanel7.indieserve.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jdt5O-00F6y7-1K; Wed, 27 May 2020 06:14:59 -0400 Date: Wed, 27 May 2020 06:14:55 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Khem Raj cc: OpenEmbedded Development mailing list Subject: Re: [oe] [PATCH] use weak assignments for PNBLACKLIST in recipe files In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-OutGoing-Spam-Status: No, score=-0.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel7.indieserve.net X-AntiAbuse: Original Domain - lists.openembedded.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Get-Message-Sender-Via: cpanel7.indieserve.net: authenticated_id: rpjday+crashcourse.ca/only user confirmed/virtual account not confirmed X-Authenticated-Sender: cpanel7.indieserve.net: rpjday@crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Content-Type: text/plain; charset=US-ASCII On Tue, 26 May 2020, Khem Raj wrote: > On Mon, May 25, 2020 at 12:21 PM Robert P. J. Day wrote: > > > > Make sure PNBLACKLIST assignments in recipe files use weak > > assignment, so they can be overridden in, for example, local.conf > > files. > > > > I would like contributions here when someone fixes one of the > blacklisted recipes. This patch will let downstream users host it in > bbappends or other places what is the intended use of this patch? i'm not sure what you're asking for here ... there is no claim that any of these recipes have been fixed in any way, only that weak assignment seems to be the default for blacklisting to at least allow for the possibility of overriding. > > > > diff --git a/meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb b/meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb > > index c39faef8d..eee96d865 100644 > > --- a/meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb > > +++ b/meta-networking/recipes-netkit/netkit-rusers/netkit-rusers_0.17.bb > > @@ -69,4 +69,4 @@ RDEPENDS_${PN}-server += "tcp-wrappers xinetd rpcbind" > > > > # http://errors.yoctoproject.org/Errors/Details/186962/ > > COMPATIBLE_HOST_libc-musl = 'null' > > -PNBLACKLIST[netkit-rusers] = "Fails to build rup.c:51:10: fatal error: rstat.h: No such file or directory" > > +PNBLACKLIST[netkit-rusers] ?= "Fails to build rup.c:51:10: fatal error: rstat.h: No such file or directory" > > diff --git a/meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb b/meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb > > index 23fe2021b..c296c3bc1 100644 > > --- a/meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb > > +++ b/meta-networking/recipes-support/drbd/drbd_9.0.19-1.bb > > @@ -22,4 +22,4 @@ do_install () { > > oe_runmake install DESTDIR="${D}" > > } > > > > -PNBLACKLIST[drbd] = "Kernel module Needs forward porting to kernel 5.2+" > > +PNBLACKLIST[drbd] ?= "Kernel module Needs forward porting to kernel 5.2+" > > diff --git a/meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb b/meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb > > index 5917cfb3e..4a1bbe620 100644 > > --- a/meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb > > +++ b/meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb > > @@ -36,4 +36,4 @@ FILES_${PN}-dbg += "${libexecdir}/lowpan-tools/.debug/" > > PACKAGES =+ "${PN}-python" > > FILES_${PN}-python = "${libdir}/python*" > > > > -PNBLACKLIST[lowpan-tools] = "WARNING these tools are deprecated! Use wpan-tools instead" > > +PNBLACKLIST[lowpan-tools] ?= "WARNING these tools are deprecated! Use wpan-tools instead" > > diff --git a/meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb b/meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb > > index 21d110aee..2e3da7d4d 100644 > > --- a/meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb > > +++ b/meta-oe/recipes-devtools/nanopb/nanopb_0.4.0.bb > > @@ -27,4 +27,4 @@ RDEPENDS_${PN} += "\ > > > > BBCLASSEXTEND = "native nativesdk" > > > > -PNBLACKLIST[nanopb] = "Needs forward porting to use python3" > > +PNBLACKLIST[nanopb] ?= "Needs forward porting to use python3" > > diff --git a/meta-oe/recipes-extended/socketcan/can-isotp_git.bb b/meta-oe/recipes-extended/socketcan/can-isotp_git.bb > > index e40e1cd26..eca8dfc7b 100644 > > --- a/meta-oe/recipes-extended/socketcan/can-isotp_git.bb > > +++ b/meta-oe/recipes-extended/socketcan/can-isotp_git.bb > > @@ -11,4 +11,4 @@ inherit module > > > > EXTRA_OEMAKE += "KERNELDIR=${STAGING_KERNEL_DIR}" > > > > -PNBLACKLIST[can-isotp] = "Kernel module Needs forward porting to kernel 5.2+" > > +PNBLACKLIST[can-isotp] ?= "Kernel module Needs forward porting to kernel 5.2+" > > diff --git a/meta-oe/recipes-kernel/bpftool/bpftool.bb b/meta-oe/recipes-kernel/bpftool/bpftool.bb > > index 6683eccf2..1758430bc 100644 > > --- a/meta-oe/recipes-kernel/bpftool/bpftool.bb > > +++ b/meta-oe/recipes-kernel/bpftool/bpftool.bb > > @@ -32,4 +32,4 @@ python do_package_prepend() { > > } > > > > B = "${WORKDIR}/${BPN}-${PV}" > > -PNBLACKLIST[bpftool] = "Needs forward porting to kernel 5.2+" > > +PNBLACKLIST[bpftool] ?= "Needs forward porting to kernel 5.2+" > > > > -- > > > > ======================================================================== > > Robert P. J. Day Ottawa, Ontario, CANADA > > http://crashcourse.ca > > > > Twitter: http://twitter.com/rpjday > > LinkedIn: http://ca.linkedin.com/in/rpjday > > ======================================================================== > > > -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================