From: Keith Busch Subject: Re: [PATCH v3 0/8] dm: add request-based blk-mq support Date: Thu, 18 Dec 2014 01:41:14 +0000 (UTC) Message-ID: References: <1418788804-1982-1-git-send-email-snitzer@redhat.com> <5491F906.1090004@kernel.dk> <20141217230622.GC15390@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141217230622.GC15390@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mike Snitzer Cc: Jens Axboe , hch@infradead.org, bvanassche@acm.org, Keith Busch , dm-devel@redhat.com, j-nomura@ce.jp.nec.com List-Id: dm-devel.ids On Wed, 17 Dec 2014, Mike Snitzer wrote: > As for blk-mq support... I don't have access to any NVMe hardware, etc. > I only tested with virtio-blk (to a ramdisk, scsi-debug, device on the > host) so I'm really going to need to lean on Keith and others to > validate blk-mq performance. There's a reason no one has multipath capable NVMe drives: they are not generally available to anyone right now. :) Mine is a prototype so not a good candidate for performance comparisons. I was able to get my loaner back a couple hours ago though, so I built and tested your tree and happy to say it is very successful. While running filesystem fio, I simulated path alternating hot-removal/add sequences and everything worked. So functionally it appears great, but I can't speak on performance right now. One thing with dual ported PCI-e SSDs is each path can be on a different pci domain local to different NUMA nodes. I think there's performance to gain if we select the target path closest to the CPU that the thread is scheduled on. I don't have data to back that up yet, but could such a path selection algorithm be considered in the future?