Received: from eggs.gnu.org ([2001:4830:134:3::10]:37233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ynp4P-00066K-An for qemu-devel@nongnu.org; Thu, 30 Apr 2015 10:04:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ynp4J-0001XL-K6 for qemu-devel@nongnu.org; Thu, 30 Apr 2015 10:04:05 -0400 Received: from mga11.intel.com ([192.55.52.93]:29842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ynp4J-0001Us-Ei for qemu-devel@nongnu.org; Thu, 30 Apr 2015 10:03:59 -0400 Date: Thu, 30 Apr 2015 14:03:56 +0000 (UTC) From: Keith Busch In-Reply-To: <20150430094417.GA18671@lst.de> Message-ID: References: <20150430094417.GA18671@lst.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Qemu-devel] [PATCH] nvme: support NVME_VOLATILE_WRITE_CACHE feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: Keith Busch , qemu-devel@nongnu.org On Thu, 30 Apr 2015, Christoph Hellwig wrote: > The SCSI emulation in the Linux NVMe driver really wants to know > if a device has a volatile write cache. Given that qemu has moved > away from a model where we report the backing store WCE bit to > one where the WCE bit is supposed to be part of the migratable > guest-visible state we always return 1 here. Thanks, this fix was long overdue and already incorporated in my tree. I really need to get my act together for a legit pull request with all the other 1.0, 1.1 and 1.2 features. Acked-by: Keith Busch > Signed-off-by: Christoph Hellwig > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 1e07166..50d76f1 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -479,6 +479,9 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeCmd *cmd, NvmeRequest *req) > req->cqe.result = > cpu_to_le32((n->num_queues - 1) | ((n->num_queues - 1) << 16)); > break; > + case NVME_VOLATILE_WRITE_CACHE: > + req->cqe.result = cpu_to_le32(1); > + break; > default: > return NVME_INVALID_FIELD | NVME_DNR; > } >