From: James Morris Subject: Re: [PATCH v6 06/10] trace/bpf_trace: open access for CAP_PERFMON privileged process Date: Wed, 29 Jan 2020 08:17:11 +1100 (AEDT) Message-ID: References: <74d524ab-ac11-a7b8-1052-eba10f117e09@linux.intel.com> <4fdbe164-d83d-a52f-4e8c-fe8bd15c6f8c@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4fdbe164-d83d-a52f-4e8c-fe8bd15c6f8c@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane-mx.org@lists.infradead.org To: Alexey Budankov Cc: Song Liu , Peter Zijlstra , "benh@kernel.crashing.org" , Alexei Starovoitov , Lionel Landwerlin , "james.bottomley@hansenpartnership.com" , Paul Mackerras , Jiri Olsa , Andi Kleen , Michael Ellerman , Igor Lubashev , Alexander Shishkin , Ingo Molnar , oprofile-list@lists.sf.net, Serge Hallyn , Robert Richter , Will Deacon , "selinux@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , Arnaldo Carvalho de Melo , Stephane Eranian List-Id: linux-perf-users.vger.kernel.org On Tue, 28 Jan 2020, Alexey Budankov wrote: > > Signed-off-by: Alexey Budankov > --- > kernel/trace/bpf_trace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > index e5ef4ae9edb5..334f1d71ebb1 100644 > --- a/kernel/trace/bpf_trace.c > +++ b/kernel/trace/bpf_trace.c > @@ -1395,7 +1395,7 @@ int perf_event_query_prog_array(struct perf_event *event, void __user *info) > u32 *ids, prog_cnt, ids_len; > int ret; > > - if (!capable(CAP_SYS_ADMIN)) > + if (!perfmon_capable()) > return -EPERM; > if (event->attr.type != PERF_TYPE_TRACEPOINT) > return -EINVAL; > Acked-by: James Morris -- James Morris