Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00388371CE0 for ; Mon, 24 Aug 2026 15:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787584959; cv=none; b=RmrqSgFXEVHpxynxe948wzDGq9H5hrvIbP/3XeO4086feImkgtMcbm69+nlBQ5aUcBo4iUs6X49Y/2Hxed0N2VcxJtJEaOLNZY0ZauXb++LT9qscrnE0rxiWT/vADFRbJQByQwwHc95OymcjVWntadtp/6GvesDiEIlwewWt0sA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787584959; c=relaxed/simple; bh=M7VHakZhxvIpK/CUFbYmyfBgA/y0vAlwhUUHkyKNhYI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EVz7YfMtB3lqh629zHUDbwfme5GCQkKttjxuMRFz+yMcWECqu3VG0fTIVOvv19CsvaM22WfACZ2U1pBrocmS2DygkhtOroghEyMWiBFCVjpkxbeWUUffcS7T/GBmYLd7dBqgEJkskEWxqDxARsS2gN/D+CuCpSj7HYNXstttjRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MW/GyNL0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=guBlAW7f; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MW/GyNL0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="guBlAW7f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787584955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=He6RFHl6rq/FSWjt0HcY9MKwV1uNr7NSbctKQDp7TZo=; b=MW/GyNL0BCUbO9s8h5DZRO525c7oEv8qpvqeEUUejpk57p+O8Vk/ju4V4KL3wgAoS+sJZg dIovVGNr1OOolpRlFbxaniDQ8F48qpYQFfQCfp3GuSp63/+vM2hDSnKvPJ7//ECaqsQWPk zivuQwFIeRK4I52/ivuVt2T7WBu/eW0= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-178-g29ooJ6TPnSKEIg8ojjycQ-1; Mon, 24 Aug 2026 11:22:34 -0400 X-MC-Unique: g29ooJ6TPnSKEIg8ojjycQ-1 X-Mimecast-MFC-AGG-ID: g29ooJ6TPnSKEIg8ojjycQ_1787584954 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-90c8da50fcfso21007366d6.1 for ; Mon, 24 Aug 2026 08:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787584954; x=1788189754; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=He6RFHl6rq/FSWjt0HcY9MKwV1uNr7NSbctKQDp7TZo=; b=guBlAW7f6lRdRFuf1Tkxlg4hQNZFuxbxDwd5E8owCp5K/Irke+ivRvzPO9Q2GPhqQS JmKrZMRNMkrKRDOyl6JOUgC9NpVaM06bmx8o/lQn9vnmas6sCnXQ923fRSoD7lgaSEDT KwyorJrmM7qlANsZNTGX4p2zR52WUWb8zKm/aEQnOp0tao+bgMp1Av+EZH0U3w4Uesn/ Lp9ik0bkDJsP+v46GXSewmQvZ172r9RVP4baYrSHQoHaSpJWWshXNKs3Cd20cuw+Vle3 5IQlbc6INuMwTeZAPmHcsl8ncJJ9YR4SHemVx5mY6gk0GQJGStEu4lz0Q0oLEq1tkEJg ovZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787584954; x=1788189754; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=He6RFHl6rq/FSWjt0HcY9MKwV1uNr7NSbctKQDp7TZo=; b=eTAxENfgKA1jgHnDxSb6UzICTwzRtg6+iQwlj98/qFob5+EfQkvu1p6xo32hJHZvhT 7YjfWZIkxrP1Yoay+J4BZrZy5ybOCy1r56/jdjPaae/I6xpv/dK4xqUc+yxEGqnJxfWM hLzvNFoc/gLriJjxxzXVTFmJfVCuCIvgi/Cmdwt9AZTAV8Mo3+G/vUkSqXgYJvd7gmfl tWyREhR59N7rVnpBgOIaijGuta+hUi+M51oCnr13jJC7yja2VVJoK9GTvYK5hNmVZP4y oMhxFfsDnDF5WDCeHQbKK+jZlgRFNawVbIVkt8ZxE+XHIELL6mqS7qOEuXZIewfwl1vM Tvzw== X-Forwarded-Encrypted: i=1; AHgh+RoT4gIlc8KCX5TfqGBOWAWsdXiaqHfXJ27gqdT+honpb6bC1QxwtNOegyjZyQiwReieyt5nEXrbvaY=@vger.kernel.org X-Gm-Message-State: AFuF++mkuNw1D8JO/3rkAdh+dl5M44+rTgqy2Deeze7PzMzVyHWtpoVu PeYWLt5E7+fhPFjHk1/12CKhiq4X66bHZiSL+VVWJHHQ/VrnlVKgt2RCh+rHQXNbh3LSxkw4n4/ 4b5ddO19jhhNa3/oJs/xEaT3xL8YN13x6ELFk73f9nOn/fhngAztxUCBW7tNqwA== X-Gm-Gg: AR+sD13mNYLU/iA7G/cf1T6QcgrFKnXvhP8tCJJu3+1IvS0cU/lYV6xuDTXdZcxc5ib /hWna3JgRsRb3Z/jMhqF1cJokI3Jq/cgqM0Uapb1c8CoE1EXYB/o3+i5eEQRnjt1XlTvcKFJ4n1 MYk3szekj+58vX6wWxKv2VmRjxdFR4EGMYIbF1xTvbwBAVbSfMC9FHivK7d+Uf6uT3VvKGsxmEr k0QcJNxhjMuTAcgo4STZYJMKu7OrmPfZAIiM7qGm1uglRebbZtH29cg/1L1c4CFvOfFyDwdHcpN LIAYNAgjD4OqoM6c9NiMCIeuCEmoe39krXKna41SbvQ9vEENyvODSXXMWFFd7vIvYHqQbVqDTzC JuM5mLEfO+tnasNVntlIhZVdxYBKSp828v+Y= X-Received: by 2002:ad4:5c89:0:b0:908:3e1c:647f with SMTP id 6a1803df08f44-90c8fa9093emr222737146d6.32.1787584953835; Mon, 24 Aug 2026 08:22:33 -0700 (PDT) X-Received: by 2002:ad4:5c89:0:b0:908:3e1c:647f with SMTP id 6a1803df08f44-90c8fa9093emr222736316d6.32.1787584953292; Mon, 24 Aug 2026 08:22:33 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c93619bbcsm64952496d6.20.2026.08.24.08.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:22:32 -0700 (PDT) Date: Mon, 24 Aug 2026 11:22:31 -0400 From: Brian Masney To: Geert Uytterhoeven Cc: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Michal Simek , Adrian Hunter , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 1/2] mmc: meson-gx: FIXME: Make sure clk_init_data is fully initialized Message-ID: References: <4b9a377a810b69a4eb885fc00cb34ef63e7fc1f1.1787240090.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b9a377a810b69a4eb885fc00cb34ef63e7fc1f1.1787240090.git.geert+renesas@glider.be> User-Agent: Mutt/2.4.0 (2026-06-19) On Fri, Aug 21, 2026 at 12:06:03PM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven It looks like the FIXME should be dropped in the commit title? With that dropped: Reviewed-by: Brian Masney