Date: Fri, 25 Sep 2026 13:48:35 -0400
From: Richard Acayan <mailingradian@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 11/11] arm64: dts: qcom: sdm670-google: configure analog
 and digital codecs
Message-ID: <araz8_AlFWLV3c3n@rdacayan>
References: <20260922015801.32373-1-mailingradian@gmail.com>
 <20260922015801.32373-12-mailingradian@gmail.com>
 <f43ebaea-05c5-40a2-882b-3211e3590476@oss.qualcomm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f43ebaea-05c5-40a2-882b-3211e3590476@oss.qualcomm.com>

On Tue, Sep 22, 2026 at 12:47:43PM +0200, Konrad Dybcio wrote:
> On 9/22/26 3:58 AM, Richard Acayan wrote:
> > The SDM660 digital and PM660L analog audio codecs control the headphone
> > jack on the Pixel 3a. Configure them for sound playback.
> > 
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
> 
> I think it's better to squash it with patch 10

Maybe it would be better to combine with patch 8 (same /^.*:/ prefix),
if this is just about number of patches. Patch 9 is about as related as
patch 10.

> [...]
> 
> 
> > +		lpi-mi2s-rx-dai-link {
> > +			link-name = "LPI MI2S Playback";
> > +
> > +			cpu {
> > +				sound-dai = <&q6afedai LPI_MI2S_RX_0>;
> > +			};
> > +
> > +			platform {
> > +				sound-dai = <&q6routing>;
> > +			};
> > +
> > +			codec {
> > +				sound-dai = <&pm660l_codec 0>,
> > +					    <&lpass_codec 0>;
> > +			};
> > +		};
> 
> nit: 'co'dec , 'cp'u < 'p'latform

(will be done in v2)