Date: Mon, 28 Sep 2026 10:55:34 -0400
From: Richard Acayan <mailingradian@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 05/11] remoteproc: qcom: pas: Add SDM670 ADSP support
Message-ID: <arp_5ts21rAgcr-P@rdacayan>
References: <20260922015801.32373-1-mailingradian@gmail.com>
 <20260922015801.32373-6-mailingradian@gmail.com>
 <58ced827-d6ec-49e1-9a2d-a4d5c4111721@oss.qualcomm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <58ced827-d6ec-49e1-9a2d-a4d5c4111721@oss.qualcomm.com>

On Tue, Sep 22, 2026 at 12:44:36PM +0200, Konrad Dybcio wrote:
> On 9/22/26 3:57 AM, Richard Acayan wrote:
> > The ADSP is used to control audio and sensors on the SDM670 SoC. Add the
> > compatible for it, with the same data as SDM845 since the driver
> > requires the load_state.
> > 
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
> >  drivers/remoteproc/qcom_q6v5_pas.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> > index ca8e61254c44..5272a462fc49 100644
> > --- a/drivers/remoteproc/qcom_q6v5_pas.c
> > +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> > @@ -1865,6 +1865,7 @@ static const struct of_device_id qcom_pas_of_match[] = {
> >  	{ .compatible = "qcom,sc8280xp-nsp1-pas", .data = &sc8280xp_nsp1_resource },
> >  	{ .compatible = "qcom,sdm660-adsp-pas", .data = &adsp_resource_init },
> >  	{ .compatible = "qcom,sdm660-cdsp-pas", .data = &cdsp_resource_init },
> > +	{ .compatible = "qcom,sdm670-adsp-pas", .data = &sdm845_adsp_resource_init },
> 
> Would a fallback compatible be suitable here?

I'll do this next revision to avoid adding the constraints in the
bindings, but I think SDM845 will only have one specific compatible.
MSM8998 and SM8150 use different data than SDM845.