DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1CBE6606A31A
Date: Tue, 27 Oct 2026 09:50:00 -0400
From: Richard Acayan <mailingradian@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 07/11] arm64: dts: qcom: sdm670: add adsp
Message-ID: <auCsCPL7gK2lIR5q@rdacayan>
References: <20261003175659.23536-1-mailingradian@gmail.com>
 <20261003175659.23536-8-mailingradian@gmail.com>
 <ya7xujl563xnvdwznmr64j24q6vao5rqdbjac7tx2azbzoezon@b7677fmbytj3>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ya7xujl563xnvdwznmr64j24q6vao5rqdbjac7tx2azbzoezon@b7677fmbytj3>

On Tue, Oct 20, 2026 at 12:37:36AM +0300, Dmitry Baryshkov wrote:
> On Sat, Oct 03, 2026 at 01:56:55PM -0400, Richard Acayan wrote:
> > The Audio DSP (Digital Signal Processor) is responsible for audio and
> > sensors on SDM670. Add this, along with the SMP2P nodes used to
> > communicate with it.
> > 
> > The sleep state is included to prevent the following crash:
> > 
> >     qcom_q6v5_pas remoteproc-adsp: fatal error received: err_qdi.c:450:EF:sensor_process:1:sar.cc:27:chre_utils fatal
> > 
> > Otherwise, it is unused.
> > 
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm670.dtsi | 168 +++++++++++++++++++++++++++
> >  1 file changed, 168 insertions(+)
> > 
> > @@ -2301,6 +2349,126 @@ cpufreq_hw: cpufreq@17d43000 {
> >  			#freq-domain-cells = <1>;
> >  		};
> >  
> > +		adsp_pas: remoteproc@62400000 {
> > +			compatible = "qcom,sdm670-adsp-pas";
> 
> Looking at your DT schema... Can we use "qcom,sdm845-adsp-pas" as a
> fallback here? Then you can drop a driver part.

Actually, looking at downstream, this should use the LCX power domain.
Can power domains be omitted like on SDM845, or is LCX important enough?