DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 57C4B606A324
DKIM2-Signature: i=1; m=1; t=1794394025; d=pks.im; mf=PHBzQHBrcy5pbT4=;
	rt=PGdpdEB2Z2VyLmtlcm5lbC5vcmc+;
	s=fm3:rsa-sha256:eV6CYlWxRUlEep7qqe+o0NIiw4QZxRD7/tLyAbC+5kzn9JY
	Yn4l75z1vdTQvhOOqduN31DnBoh9imCsAD7C8FgmIiZYJB5AcG8Cj4PcU2J686Vj
	uEKyYEtnkQdmld90YJym/Jctb6B0kIVah75FsUsRPDTXCfdoLT2jNWVhAgVu6HnR
	lCP5nTGCDbTWodG6bGm/gl9iBQxyiuMUsDgKGYHgxFDU9hXmXfe5o+cbRR7X47U2
	HJbRd19GLT0My1BisZeXhJDrK1zKhHh3eMJqz/MTUBHAxXFnokgPDtcx/Titm+hO
	kTqL35gv79nyZURQcDvgt5yWZ+OLYbBUHbOwmvg==;
Message-Instance: m=1; h=sha256:7mjTIs/EKyeXbnCGstfcXpGVRIrK/GAmSaMdfF77BMY=:ETrK3+GvrSuNipSk3+yZDggb5loIpyItgOA5XZCEgLc=;
Feedback-ID: i197146af:Fastmail
Date: Wed, 11 Nov 2026 11:46:59 +0100
From: Patrick Steinhardt <ps@pks.im>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: Karthik Nayak <karthik.188@gmail.com>,
	Phillip Wood <phillip.wood123@gmail.com>,
	Jelle van der Waa <jelle@vdwaa.nl>, git@vger.kernel.org,
	Junio C Hamano <gitster@pobox.com>,
	Phillip Wood <phillip.wood@dunelm.org.uk>,
	Harald Nordgren <haraldnordgren@gmail.com>,
	=?utf-8?B?UmVuw6k=?= Scharfe <l.s.r@web.de>
Subject: Re: [RFC PATCH 0/2] Support --verbose in git history
Message-ID: <avRHowwvxoo3e78H@pks.im>
References: <CAOLa=ZQowi+fepj+RNegTZhK_Jy4G8VLE_Af2UdsO8-rCdviJQ@mail.gmail.com>
 <53CA2747-58F6-4A7C-81EC-33EABF0000FC@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <53CA2747-58F6-4A7C-81EC-33EABF0000FC@gmail.com>

On Tue, Nov 10, 2026 at 12:15:20PM -0500, Ben Knoble wrote:
> 
> 
> > Le 10 nov. 2026 à 08:13, Karthik Nayak <karthik.188@gmail.com> a écrit :
> > 
> > ﻿Phillip Wood <phillip.wood123@gmail.com> writes:
> > 
> >>> On 09/11/2026 12:43, D. Ben Knoble wrote:
> >>> On Mon, Nov 9, 2026 at 7:06 AM Karthik Nayak <karthik.188@gmail.com> wrote:
> >>>> 
> >>>> My preference would be to make this (current patch) default behavior and
> >>>> not even have an option. I don't see a disadvantage of having the diff
> >>>> always being shown and it definitely is a better default to have.
> >>> 
> >>> When the diff is extremely long, or if the user has other means of
> >>> obtaining it and wants the editor to open quickly, it may not be
> >>> desired. So I'd prefer to still have it optional, personally.
> >> 
> >> Another case where we might not want the diff is scripted editing as it
> >> is much easier if the script does not have to worry about the diff
> >> getting in the way of its edits. Personally I'd be happy to see this on
> >> by default - the history command is marked as experimental so if having
> >> it on by default rather than following "commit.verbose" proves to be
> >> problematic we can always change it in the future. If we were staring
> >> again I'd also make "commit.verbose" on by default as well so maybe I'm
> >> biased.
> >> 
> >> Thanks
> >> 
> >> Phillip
> > 
> > I'm on board with this suggestion. Plus, I see 'git history' to be more
> > user facing and it's always nicer to have better defaults for users.
> > Showing diffs and verbose information seems to be inline with that. We
> > could add an option to disable such output for scripts (but that can be
> > done later as you suggested).
> > <signature.asc>
> 
> I can live with opt-out as long as I can turn it off via config.

Yeah, agreed. For me there's two important parts, where being able to
disable this is the first one. The second part is that we need to make
sure that such a format can work for every subcommand of git-history(1)
so that we don't have to have multiple different formats for it.

Patrick