DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 100BF606A884
Date: Wed, 11 Nov 2026 18:57:11 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Pratik R. Sampat" <prsampat@amd.com>
Cc: mcgrof@kernel.org, russ.weight@linux.dev, dakr@kernel.org,
	ashish.kalra@amd.com, thomas.lendacky@amd.com, davem@davemloft.net,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, rafael@kernel.org, chao.gao@intel.com,
	aik@amd.com, tycho@kernel.org, nikunj@amd.com, michael.roth@amd.com,
	shansinha@google.com
Subject: Re: [Patch v5 7/7] crypto: ccp - Implement SNP Download Firmware EX
Message-ID: <avRKB59olTJmKQun@gondor.apana.org.au>
References: <cover.1792599491.git.prsampat@amd.com>
 <fe86fe10f9def87a2b463a6d4b44e266dd9497dc.1792599491.git.prsampat@amd.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fe86fe10f9def87a2b463a6d4b44e266dd9497dc.1792599491.git.prsampat@amd.com>

On Wed, Oct 21, 2026 at 05:05:03PM +0000, Pratik R. Sampat wrote:
> Implement SNP live firmware update using the DOWNLOAD_FIRMWARE_EX
> command.
> 
> DOWNLOAD_FIRMWARE_EX requires the legacy SEV platform to be UNINIT. If
> it is WORKING then legacy guests are running and the update is refused
> as busy. If it is INIT, shut it down, release the buffers the firmware
> owns across that shutdown, run the update, and bring the platform back
> up afterwards. SNP is never taken down, so SNP guests are unaffected.
> 
> To test run the following with your sbin file in FW:
> 
> echo 1 > /sys/class/firmware/sev/loading
> cat <firmware.sbin> > /sys/class/firmware/sev/data
> echo 0 > /sys/class/firmware/sev/loading
> 
> The COMMIT bit is left clear, so the image is only loaded provisionally
> and the admin decides when to make it permanent with ioctl(/dev/sev,
> SNP_COMMIT). To roll back, do not commit and upload the previous image
> the same way.
> 
> Co-developed-by: Tycho Andersen (AMD) <tycho@kernel.org>
> Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
> Signed-off-by: Pratik R. Sampat <prsampat@amd.com>
> ---
> v4..v5:
> * Report original firmware error on rollback failure - Tycho, Shantanu
> ---
>  drivers/crypto/ccp/sev-dev.c | 297 ++++++++++++++++++++++++++++++++++-
>  drivers/crypto/ccp/sev-dev.h |   2 +
>  include/linux/psp-sev.h      |  19 +++
>  3 files changed, 317 insertions(+), 1 deletion(-)

Sashiko has a comment on this patch:

https://sashiko.dev/#/patchset/cover.1792599491.git.prsampat%40amd.com

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt