Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.11 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795161291; b=L5IL9bqS4jW6Jdsr2ehVSJZG+INmfUChF/Xx/F+ImcAVt/y4D97z4ybmRpJkEuWF/3a/ HSJLGx8lKV2qrYpNfet0y6o4iv2Go322W3ZcjFnEdCn0Zl332oICqf9x4n/DaslPk9Cl8 ClCtEW561BeEuDcVjSmJhJ7WdiY8OaKnV3bKbYUf25TNS8JDAyzRM9S+hnE7MmD4OQVYc BZYPOqhwxZMb8DRZSVDRuyqUqibaOonLuRNY1N2cafh6GdA5Y/pHpr+MBLfvc65TPWQPR EeLBZnuS9gLU+UCeU6jyaToLaLD/VIXXSPtzigwnahyVY75TaWJDmwt/dIDHrljFWMw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795161291; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=EcdGgSDI9tb73+UaHZHy54ezEElM8g26EHhMkNH595g=; b=knuwNd+uTCuBAJWsKabM1lkAZVd8sJVJ9KbkepUx4mrByOg6u3GQLUIQbSaQzU/etwpg IdX5uU4/rSV1sp3UyY/eamVRTM/yWUBrPyOISgfDiAQKXdtGnFJWV6bJuDPj6ILhg68Aq O9kaz4ouCv8X1Tnrrt4JIQQWQTAATJznqQ7ujo5WUrdjckE+z1KsDbrvlJreLqWbrrUSl B/CSeL/DxKdHazdKdZKrGy2TPqKg1bu+f8L35pu1CHXxEMJ2HheI/f+sUiRDlzb/xIHP8 cTemjEtbtr/YCUCLj1xLESXrC6dZt5D0tjmB7k+X2wOyRj1ABaV8nvpXbo2RKyoQmvg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WU+sabc+; arc=none smtp.remote-ip=192.198.163.11 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 567D4606A325 for ; Fri, 20 Nov 2026 07:54:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 567D4606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WU+sabc+ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795161290; x=1826697290; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=juVBVKqACIcRlOQSiNY74SwgubrapxhHOuBZ6EPGGtw=; b=WU+sabc+zcL031VSdraERS6E0/kFw8NCON+PN9SuDnfEeEB5m4S4MPlP GolYQDn0H940EhJRNgy9r9W7FJKlOq1CsKka4Iex3Sm/4mq9lKsPej2Tt 9x64ILL1GyzojH9fSfiV8M6jY7qJFGoDwEYUHQFHImFFOQuZz9ZT+MwZe BNF+BfBFIlo4Kns46xzbsy85CdBQglGZBgfXth7fJjfE7NaeL3u0MmPw5 T3l/jIBN3QON4afccghzjdJwUw79K6wWnWt/ebNA+5LZVl3+9KVXTXvxw QLxzK9f+kbKBz1JMnoGJN8s8s/qNm25NWjn3qO2SKwVqctuVqpl76/7nZ g==; X-CSE-ConnectionGUID: J3c6gymDRAeKlzM3fE08IQ== X-CSE-MsgGUID: WTBODQhQQYGcD2iCnAPrNQ== X-IronPort-AV: E=McAfee;i="6800,10657,11971"; a="3951297" X-IronPort-AV: E=Sophos;i="6.27,222,1787036400"; d="scan'208";a="3951297" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2026 23:54:50 -0800 X-CSE-ConnectionGUID: BRFsG67gQYCBxavcMBdcgA== X-CSE-MsgGUID: Z6+Jqpz+RkWMrHEQgyvTzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,222,1787036400"; d="scan'208";a="10454883" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2026 23:54:48 -0800 Date: Fri, 20 Nov 2026 08:54:46 +0100 From: Raag Jadav To: sashiko-reviews@lists.linux.dev Cc: Badal Nilawar , intel-xe@lists.freedesktop.org Subject: Re: [PATCH v8 2/3] drm/xe/xe_ras: Add support to retrieve info queue data Message-ID: References: <20261120043303.107183-5-badal.nilawar@intel.com> <20261120043303.107183-7-badal.nilawar@intel.com> X-Mailing-List: sashiko-reviews@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 20, 2026 at 04:42:00AM +0000, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential > issue to consider: > - [Medium] drm/xe/ras: assertion and 0-byte fetch in > get_remaining_chunks() when full > -- > > commit 6c6fff86d117ac6d5e465e2c1c62372c93a7e520 > Author: Badal Nilawar > > drm/xe/xe_ras: Add support to retrieve info queue data > > This commit adds helpers and mailbox structures to retrieve RAS info queue > data in chunks and assemble it into a flat buffer. > > > diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c > > index e8984c966876a..46542852e0552 100644 > > --- a/drivers/gpu/drm/xe/xe_ras.c > > +++ b/drivers/gpu/drm/xe/xe_ras.c > > @@ -1123,6 +1123,192 @@ int xe_ras_set_threshold(struct xe_device *xe, u8 severity, u8 component, u32 th > > [ ... ] > > > +static u32 get_remaining_chunks(struct xe_device *xe, > > + const struct xe_ras_get_counter_response *counter_resp, > > + u8 *dest_buf, u32 dest_size, u32 offset, u32 flags) > > +{ > > + u32 requests_left = XE_SYSCTRL_FLOOD_LIMIT * 2; > > + int ret; > > + > > + while (flags & XE_RAS_INFO_QUEUE_FLAG_MORE_DATA) { > > + struct xe_ras_info_queue_data_request *qdata_req; > > + struct xe_ras_get_info_queue_response response = {}; > > + struct xe_ras_get_info_queue_request request = {}; > > + struct xe_ras_info_queue_header *hdr; > > + > > + xe_assert(xe, offset < dest_size); > > + > > + qdata_req = &request.qdata_req; > > + qdata_req->offset = offset; > > + qdata_req->size = min_t(u32, XE_RAS_INFO_QUEUE_MAX_CHUNK_SIZE, dest_size - offset); > > + qdata_req->session_id = counter_resp->counter; > > + > > + ret = get_info_queue(xe, &request, &response); > > + if (ret) { > > + xe_err(xe, "[RAS]: info queue drain aborted: fetch at offset=%u, ret = %d\n", > > + offset, ret); > > + return offset; > > + } > > + > > + hdr = &response.qdata_resp.header; > > + > > + if (!chunk_is_valid(hdr, offset, counter_resp->first.header.total_size, > > + dest_size)) { > > + xe_warn(xe, "[RAS]: invalid info queue chunk (total=%u offset=%u size=%u, expected offset=%u)\n", > > + hdr->total_size, hdr->chunk_offset, hdr->chunk_size, offset); > > + return offset; > > + } > > + > > + memcpy(dest_buf + offset, response.qdata_resp.data, hdr->chunk_size); > > + offset += hdr->chunk_size; > > + flags = hdr->flags; > > + > > + if (!--requests_left) { > > + xe_warn(xe, "[RAS]: info queue flooding, aborted at offset=%u\n", offset); > > + break; > > + } > > + } > > [Severity: Medium] > Can get_remaining_chunks() trip xe_assert(xe, offset < dest_size) and issue > a 0-byte GET_INFO_QUEUE request when dest_buf fills up while > XE_RAS_INFO_QUEUE_FLAG_MORE_DATA is still set? True, the assert should actually be xe_assert(xe, offset <= dest_size); Raag