References: <20210812075757.31759-1-a@...2181...> <20210812085300.4738-1-a@...2181...> From: Max Fillinger Message-ID: Date: Thu, 12 Aug 2021 12:22:45 +0200 MIME-Version: 1.0 In-Reply-To: <20210812085300.4738-1-a@...2181...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH v2] mbedtls: do not define mbedtls_ctr_drbg_update_ret when not needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit To: Antonio Quartulli , openvpn-devel@lists.sourceforge.net On 12/08/2021 10:53, Antonio Quartulli wrote: > The mbedtls_ctr_drbg_update_ret() function was backported to various > older branches, including 2.14 and 2.7. > To aqvoid making the if guard too complex, let's detect if this function > exist at configure time. > All versions not having this function, will use our compat code. > > Cc: Max Fillinger > Signed-off-by: Antonio Quartulli Thanks again for cleaning up my mess! Compile-tested with mbedtls versions 2.27.0 2.26.0 2.25.0 2.16.11 2.15.1 2.14.1 2.14.0 2.12.0 2.7.19 2.7.0 All good! (Typo: "aqvoid" in the commit message, but that can be fixed when committing it, right?) Acked-by: Max Fillinger