From: Vineet Gupta Subject: Re: arc_usr_cmpxchg and preemption Date: Fri, 16 Mar 2018 10:54:52 -0700 Message-ID: References: <1521045375.11552.27.camel@synopsys.com> <20180314175352.GP4064@hirez.programming.kicks-ass.net> <1521221606.4805.16.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1521221606.4805.16.camel@synopsys.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alexey Brodkin , "peterz@infradead.org" Cc: "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" List-Id: linux-arch.vger.kernel.org On 03/16/2018 10:33 AM, Alexey Brodkin wrote: > Hi Peter, Vineet, > > On Wed, 2018-03-14 at 18:53 +0100, Peter Zijlstra wrote: >> On Wed, Mar 14, 2018 at 09:58:19AM -0700, Vineet Gupta wrote: >> >>> Well it is broken wrt the semantics the syscall is supposed to provide. >>> Preemption disabling is what prevents a concurrent thread from coming in and >>> modifying the same location (Imagine a variable which is being cmpxchg >>> concurrently by 2 threads). >>> >>> One approach is to do it the MIPS way, emulate the llsc flag - set it under >>> preemption disabled section and clear it in switch_to >> *shudder*... just catch the -EFAULT, force the write fault and retry. > More I look at this initially quite simple thing more it looks like > a can of worms... > I'd say just bite the bullet, write the patch and we can refine it there ! -Vineet