Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ihWTv-0005oS-AO for mharc-qemu-trivial@gnu.org; Wed, 18 Dec 2019 05:23:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39062) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihWTt-0005lq-LT for qemu-trivial@nongnu.org; Wed, 18 Dec 2019 05:23:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihWTr-0007GH-W5 for qemu-trivial@nongnu.org; Wed, 18 Dec 2019 05:23:00 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:23841 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihWTr-00077d-S9 for qemu-trivial@nongnu.org; Wed, 18 Dec 2019 05:22:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576664578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cXxkLuAPk7h/79LrlTPz3Lq+iVKhj6zC9LVXFOliBfA=; b=D+C9O2MzWffDL5VF1sNg5rDj5D8wNKPaDjskexEcF9Fp9kTxypEkT9JwiZ0lWqI1osaZ5Q tix2ZyfdgkNqmLqHtVbPZ9514Qw7g5QfW25KEIjjkSsMWzS9UkhIsFOIlK6v/DaTONcm6g mdVtfOZfMY4tAyPAmS9NLjWogbtCS10= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-NfsCXUt6OqeXkYbNjbKHmA-1; Wed, 18 Dec 2019 05:22:56 -0500 Received: by mail-wr1-f70.google.com with SMTP id h30so688166wrh.5 for ; Wed, 18 Dec 2019 02:22:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=21mfIMHBAT7U6xxsVx3L46a3fn7/m2C1a/m77gUaPpk=; b=GwUw1Bj7tKleT4Ib1Yh4+7K3/AlI+vNoNLj4+2bU5Fcj7XjwPavOhOuisIGrzvaJic N/ECBtBon0K6Jyy3DVeRSoANoukjdYMHOvJljWQz2pjqQwiUXyHHzahWu1Raj5Clwiz5 DG9udFKIyCYpeY1EQdSCCRt397EbogisRA7ux1Udzo77b0rsapniaiJvbe34XajFbjyl Xs2ol2PkxMI8oyZ4PqV98AaRTufikkBHJdptDQJwfXT2WqcNEzVsAxw0cqCXLV9FYkhc LVLtJ/ZBCRpsz8f10koxqSBsKrSKMhUUjMpNtjuC192iCmArJlPY5U6wunVhNOZJ8Z3Y v63w== X-Gm-Message-State: APjAAAVC4VvIy3Z4qQRbzZ+mL9DMDocqKTG7oWuVkPAHRnuY+DWtNz/j 1m5drnOZbqw0IP5zVJ4kUMBcHQmyg41rx1ros5mt23FjmwdYlfLm8aVSU3HvtZh47mOALr29u/I kRROQWOLpBeF1iqV51A== X-Received: by 2002:a1c:3803:: with SMTP id f3mr2415926wma.134.1576664575752; Wed, 18 Dec 2019 02:22:55 -0800 (PST) X-Google-Smtp-Source: APXvYqw5LGGsrumjmrTsb6970lo+QTIsUtkse8oTu9qkw7HKModLQtxZa1oH9bX7NIL2JVlKY9kE/A== X-Received: by 2002:a1c:3803:: with SMTP id f3mr2415911wma.134.1576664575563; Wed, 18 Dec 2019 02:22:55 -0800 (PST) Received: from [192.168.23.166] (40.red-88-21-19.staticip.rima-tde.net. [88.21.19.40]) by smtp.gmail.com with ESMTPSA id m3sm2049924wrs.53.2019.12.18.02.22.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Dec 2019 02:22:55 -0800 (PST) Subject: Re: [PATCH 1/6] audio/audio: Add missing fall through comment To: Aleksandar Markovic Cc: "qemu-devel@nongnu.org" , "qemu-trivial@nongnu.org" , Gerd Hoffmann , =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= References: <20191217173425.5082-1-philmd@redhat.com> <20191217173425.5082-2-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 18 Dec 2019 11:22:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-MC-Unique: NfsCXUt6OqeXkYbNjbKHmA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Dec 2019 10:23:02 -0000 On 12/18/19 9:02 AM, Aleksandar Markovic wrote: >=20 >=20 > On Tuesday, December 17, 2019, Philippe Mathieu-Daud=C3=A9 > wrote: >=20 > GCC9 is confused by this comment when building with > CFLAG -Wimplicit-fallthrough=3D2: >=20 >=20 > Gcc is not confused whatsoever. It is right! I'll update the description :) >=20 > =C2=A0 audio/audio.c: In function =E2=80=98audio_pcm_init_info=E2=80= =99: > =C2=A0 audio/audio.c:306:14: error: this statement may fall through > [-Werror=3Dimplicit-fallthrough=3D] > =C2=A0 =C2=A0 306 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0sign =3D 1; > =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0~~~~~= ^~~ > =C2=A0 audio/audio.c:307:5: note: here > =C2=A0 =C2=A0 307 |=C2=A0 =C2=A0 =C2=A0case AUDIO_FORMAT_U8: > =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0^~~~ > =C2=A0 cc1: all warnings being treated as errors >=20 > Add the missing fall through comment, similarly to e46349414. >=20 > Fixes: 2b9cce8c8c > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > --- > Cc: Gerd Hoffmann > > Cc: "K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n" > > --- > =C2=A0audio/audio.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/audio/audio.c b/audio/audio.c > index 56fae55047..57daf3f620 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info > *info, struct audsettings *as) > =C2=A0 =C2=A0 =C2=A0switch (as->fmt) { > =C2=A0 =C2=A0 =C2=A0case AUDIO_FORMAT_S8: > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0sign =3D 1; > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* fall through */ > =C2=A0 =C2=A0 =C2=A0case AUDIO_FORMAT_U8: > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mul =3D 1; > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break; > --=20 > 2.21.0 >=20 >=20