Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C394AC54EBD for ; Fri, 13 Jan 2023 13:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241306AbjAMNtQ (ORCPT ); Fri, 13 Jan 2023 08:49:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241876AbjAMNsi (ORCPT ); Fri, 13 Jan 2023 08:48:38 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAFC61FF for ; Fri, 13 Jan 2023 05:43:53 -0800 (PST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NtjJT5SbjzRrDL; Fri, 13 Jan 2023 21:42:01 +0800 (CST) Received: from [10.67.109.184] (10.67.109.184) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 13 Jan 2023 21:43:46 +0800 Message-ID: Date: Fri, 13 Jan 2023 21:43:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH bpf-next 07/25] libbpf: complete riscv arch spec in bpf_tracing.h Content-Language: en-US To: Andrii Nakryiko , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , , , CC: , Alan Maguire , Ilya Leoshkevich , Hengqi Chen , Vladimir Isaev , Kenta Tada , Florent Revest References: <20230113083404.4015489-1-andrii@kernel.org> <20230113083404.4015489-8-andrii@kernel.org> From: Pu Lehui In-Reply-To: <20230113083404.4015489-8-andrii@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.109.184] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 2023/1/13 16:33, Andrii Nakryiko wrote: > Add PARM6 through PARM8 definitions for RISC V (riscv) arch. Leave the > link for ABI doc for future reference. > > Signed-off-by: Andrii Nakryiko > --- > tools/lib/bpf/bpf_tracing.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/lib/bpf/bpf_tracing.h b/tools/lib/bpf/bpf_tracing.h > index 0f9640ddbe1c..579e2f830532 100644 > --- a/tools/lib/bpf/bpf_tracing.h > +++ b/tools/lib/bpf/bpf_tracing.h > @@ -268,12 +268,19 @@ struct pt_regs___arm64 { > > #elif defined(bpf_target_riscv) > > +/* > + * https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-cc.adoc#risc-v-calling-conventions > + */ > + > #define __PT_REGS_CAST(x) ((const struct user_regs_struct *)(x)) > #define __PT_PARM1_REG a0 > #define __PT_PARM2_REG a1 > #define __PT_PARM3_REG a2 > #define __PT_PARM4_REG a3 > #define __PT_PARM5_REG a4 > +#define __PT_PARM6_REG a5 > +#define __PT_PARM7_REG a6 > +#define __PT_PARM8_REG a7 > #define __PT_RET_REG ra > #define __PT_FP_REG s0 > #define __PT_RC_REG a0 Hi Andrii, Looks fine and tests passed as follow: #233 uprobe_autoattach:OK Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED #19 bpf_syscall_macro:OK Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED Tested-by: Pu Lehui # RISC-V Best Regards, Lehui