From: Markus Elfring Date: Sun, 24 May 2020 07:00:28 +0000 Subject: Re: [PATCH v2 1/2] drivers: provide devm_platform_request_irq() Message-Id: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dejin Zheng , linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org Cc: Ard Biesheuvel , Barry Song , Baruch Siach , Fabio Estevam , Florian Fainelli , Greg Kroah-Hartman , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Kevin Hilman , Linus Walleij , Michal Simek , Paul Cercueil , "Rafael J. Wysocki" , Ray Jui , Scott Branden , Shawn Guo , Vladimir Zapolskiy , Wolfram Sang , linux-kernel@vger.kernel.org, Coccinelle > It will call devm_request_irq() after platform_get_irq() function > in many drivers, sometimes, it is not right for the error handling > of these two functions in some drivers. so provide this function > to simplify the driver. I recommend to improve also this change description. How do you think about a wording variant like the following? The function “devm_request_irq” is called after the function “platform_get_irq” in many drivers. The exception handling is incomplete there sometimes. Thus add a corresponding wrapper function for the simplification of the drivers. Will a companion script for the semantic patch language (Coccinelle software) become helpful for further support of collateral evolution? Regards, Markus