Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F688C4706C for ; Tue, 16 Jan 2024 10:32:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D8E1910E475; Tue, 16 Jan 2024 10:32:04 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D18D10E475 for ; Tue, 16 Jan 2024 10:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705401123; x=1736937123; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6LhUlm2M66TrWHNleKQ0IdrVGaYiYHLDSH/yZa0ti+s=; b=j6zpfGnm/0PHMX1kFS9qrQs6Ad/dn2UUlTZGGtpfP/BLysGh5Ums1j0L bHK+etGnTE9kE1XGFn7W++eS3Oetc41jMbsab6D1AXBvuKDg2A5yFSgwU hpBF8ZfcU9A7vZo6YbjsU8B+20zFt/Zm2w3nQ4n9BGi8UWz1AuuMp1AWa IDLzO5yPch3IFzryYrc6YfiLamXYZ8r7ivraFy70z3DX5zdom2I0dz1Bz 5bZhAyAGZDrkFhs7XNnG+dIb+f/lvHALoyFpsiTGOBH/uIkjgG/80M4pW DPSCO6B6IllX8RI0lYGvWg09hFJ3MvxOpgXw056drUxeH7IQjpibeWdGO w==; X-IronPort-AV: E=McAfee;i="6600,9927,10954"; a="7190356" X-IronPort-AV: E=Sophos;i="6.04,198,1695711600"; d="scan'208";a="7190356" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2024 02:32:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10954"; a="903076485" X-IronPort-AV: E=Sophos;i="6.04,198,1695711600"; d="scan'208";a="903076485" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.246.32.218]) ([10.246.32.218]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2024 02:32:01 -0800 Message-ID: Date: Tue, 16 Jan 2024 11:32:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/16] drm/i915: Disable the "binder" Content-Language: en-US To: Ville Syrjala , intel-gfx@lists.freedesktop.org References: <20240116075636.6121-1-ville.syrjala@linux.intel.com> <20240116075636.6121-6-ville.syrjala@linux.intel.com> From: Nirmoy Das In-Reply-To: <20240116075636.6121-6-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 1/16/2024 8:56 AM, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that the GGTT PTE updates go straight to GSMBASE (bypassing > GTTMMADR) there should be no more risk of system hangs? So the > "binder" (ie. update the PTEs via MI_UPDATE_GTT) is no longer > necessary, disable it. > > My main worry with the MI_UPDATE_GTT are: > - only used on this one platform so very limited testing coverage > - async so more opprtunities to screw things up > - what happens if the engine hangs while we're waiting for MI_UPDATE_GTT > to finish? > - requires working command submission, so even getting a working > display now depends on a lot more extra components working correctly > > TODO: MI_UPDATE_GTT might be interesting as an optimization > though, so perhaps someone should look into always using it > (assuming the GPU is alive and well)? > > v2: Keep using MI_UPDATE_GTT on VM guests > > Cc: Paz Zcharya > Cc: Nirmoy Das > Signed-off-by: Ville Syrjälä Reviewed-by: Nirmoy Das > --- > drivers/gpu/drm/i915/gt/intel_gtt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c > index 86f73fe558ca..e83dabc56a14 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gtt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c > @@ -24,7 +24,8 @@ > bool i915_ggtt_require_binder(struct drm_i915_private *i915) > { > /* Wa_13010847436 & Wa_14019519902 */ > - return MEDIA_VER_FULL(i915) == IP_VER(13, 0); > + return i915_run_as_guest() && > + MEDIA_VER_FULL(i915) == IP_VER(13, 0); > } > > static bool intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *i915)