From: "plaisthos (Code Review)"
Date: Wed, 13 Dec 2023 14:11:20 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="dYhp+LMjQBY="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit
test and test export of PEM to file
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , openvpn-devel
--dYhp+LMjQBY=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/471?usp=3Demail )
Change subject: Add test_ssl unit test and test export of PEM to file
......................................................................
Patch Set 2:
(3 comments)
File tests/unit_tests/openvpn/Makefile.am:
http://gerrit.openvpn.net/c/openvpn/+/471/comment/2bd17b5f_bc89de26 :
PS2, Line 86: $(top_srcdir)/src/openvpn/xkey_provider.c \
> indent
Done
File tests/unit_tests/openvpn/mock_management.c:
http://gerrit.openvpn.net/c/openvpn/+/471/comment/2c367b9e_17b39eb9 :
PS2, Line 49: (void) man;
> inconsistent (void), used it in one function, but not the other
Done
File tests/unit_tests/openvpn/test_ssl.c:
http://gerrit.openvpn.net/c/openvpn/+/471/comment/1f8780a6_702527f1 :
PS2, Line 47: /* Mock function to be allowed to include win32.c which is re=
quired for
> You originally created win32-util. [=E2=80=A6]
I didn't like the idea of pulling the dependency of msg() to that file. Cur=
rently that util file is standalone. I modified the approach to avoid that =
dependency.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381
Gerrit-Change-Number: 471
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 13 Dec 2023 14:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--dYhp+LMjQBY=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
inconsistent (void), used it=
in one function, but not the other
Done
File tests/unit_tests/openvpn/test_ssl.c:
Patch Set #2, Line 47: <=
code style=3D"font-family:monospace,monospace">/* Mock function to be allow=
ed to include win32.c which is required for
You orig=
inally created win32-util. [=E2=80=A6]
I didn't like the idea of pullin=
g the dependency of msg() to that file. Currently that util file is standal=
one. I modified the approach to avoid that dependency.
=
ul>
To view, visit change 471. To unsubscribe, or for help writing mail filter=
s, visit settings.